From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label
Date: Mon, 23 Apr 2012 22:28:32 -0700 [thread overview]
Message-ID: <20120424052832.GA28787@core.coreip.homeip.net> (raw)
In-Reply-To: <1334609092-15338-1-git-send-email-Julia.Lawall@lip6.fr>
On Mon, Apr 16, 2012 at 10:44:52PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> At the point of this error-handling code, aiptek->urb has been allocated,
> and it does not appear to be less necessary to free it here than in the
> error-handling code just below.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thank you Julia.
>
> ---
> drivers/input/tablet/aiptek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
> index 205d16a..a33d347 100644
> --- a/drivers/input/tablet/aiptek.c
> +++ b/drivers/input/tablet/aiptek.c
> @@ -1856,7 +1856,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
> if (i == ARRAY_SIZE(speeds)) {
> dev_info(&intf->dev,
> "Aiptek tried all speeds, no sane response\n");
> - goto fail2;
> + goto fail3;
> }
>
> /* Associate this driver's struct with the usb interface.
>
--
Dmitry
prev parent reply other threads:[~2012-04-24 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 20:44 [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label Julia Lawall
2012-04-24 5:28 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424052832.GA28787@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).