From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Henrik Rydberg" Subject: Re: [PATCH 2/6] hid: Scan the device for group info before adding it Date: Tue, 24 Apr 2012 14:41:13 +0200 Message-ID: <20120424124113.GA10055@polaris.bitmath.org> References: <1335175627-2270-1-git-send-email-rydberg@euromail.se> <1335175627-2270-3-git-send-email-rydberg@euromail.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtprelay-b11.telenor.se ([62.127.194.20]:39529 "EHLO smtprelay-b11.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700Ab2DXMhc (ORCPT ); Tue, 24 Apr 2012 08:37:32 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org > > +static int hid_scan_report(struct hid_device *hid) > > +{ > > + unsigned int page = 0, delim = 0; > > + __u8 *start = hid->dev_rdesc; > > + __u8 *end = start + hid->dev_rsize; > > Where do these dev_rdesc and dev_rsize come from? Your patchset doesn't > seem to be changing the corresponding struct device members (which are > rdesc and rsize currently), right? Those members are added in the enable-report-fixup-on-rebind patchset, which this patchset builds on. I only sent that patchset once, to avoid confusion. Maybe I created some instead. :-) And yes, the scanning algorithms do not touch the rdesc/rsize variables, nor the collection state. Those are handled upon attachment of the driver. Thanks, Henrik