From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Henrik Rydberg" Subject: Re: [PATCH v3 0/6] hid: Introduce device groups Date: Thu, 3 May 2012 14:23:59 +0200 Message-ID: <20120503122359.GA11552@polaris.bitmath.org> References: <1335175627-2270-1-git-send-email-rydberg@euromail.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtprelay-b21.telenor.se ([195.54.99.212]:43659 "EHLO smtprelay-b21.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243Ab2ECMTW (ORCPT ); Thu, 3 May 2012 08:19:22 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: Jiri Kosina , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Stephane Chatty > I'm currently on the bug fix I told you earlier. However, I found a > more problematic bug in the hid_groups functionality. > > Some device, like the Perixx peripad, present several interfaces > (mouse, keyboard and multitouch). > The hid groups functionality detects the HID field Contact ID, and > then forwards all interfaces to hid-multitouch. The point is that > hid-multitouch does not know how to handle mice and keyboards, and > then fails handling the interfaces of the device. I am a bit unclear as to which devices this applies to, but I see two possible solutions: 1) Add the devices in question back to the have_special_drivers list. 2) Add the interface type to the group descision, which should probably be done anyway. I have a patch in the pipe that, will send it later today. > This particular device is then fully broken (as anyone pumped the events). > I also noticed the same problem (but less problematic) with cypress > panels: it presents different vendor interfaces and they are handled > by hid-multitouch. It would be great if you could test soution 1) before on a device - something seems wrong if those interfaces were handled by hid-generic before, but before getting the logic straight, it does not hurt to try. :-) Thanks, Henrik