[PATCH] TWL6040: fix build error

[PATCH] TWL6040: fix build error

[Sasha Levin]

Fixes build error due to missing of_property_read_u32.

Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
 drivers/input/misc/twl6040-vibra.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
index bb134ce..97447ee 100644
--- a/drivers/input/misc/twl6040-vibra.c
+++ b/drivers/input/misc/twl6040-vibra.c
@@ -27,6 +27,7 @@
  */
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/workqueue.h>
 #include <linux/input.h>
-- 
1.7.8.5

Re: [PATCH] TWL6040: fix build error

[Paul Gortmaker]

On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> Fixes build error due to missing of_property_read_u32.

Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
this missing header, it needs to have a Kconfig dependency that limits
it to just being enabled on the platforms where it physically is possible to
have the hardware.  I'm guessing limiting to ARM would be a good start?

Thanks,
Paul.
--

>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  drivers/input/misc/twl6040-vibra.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
> index bb134ce..97447ee 100644
> --- a/drivers/input/misc/twl6040-vibra.c
> +++ b/drivers/input/misc/twl6040-vibra.c
> @@ -27,6 +27,7 @@
>  */
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> +#include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/workqueue.h>
>  #include <linux/input.h>
> --
> 1.7.8.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Sasha Levin]

On Fri, May 11, 2012 at 12:49 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> Fixes build error due to missing of_property_read_u32.
>
> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> this missing header, it needs to have a Kconfig dependency that limits
> it to just being enabled on the platforms where it physically is possible to
> have the hardware.  I'm guessing limiting to ARM would be a good start?

I'm not sure how the actual hardware looks or even what it does, i
just wanted to make sure that it doesn't break my x86 build. Which is
why I'd rather not modify anything further than what I did in this
patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Paul Gortmaker]

[Re: [PATCH] TWL6040: fix build error] On 11/05/2012 (Fri 04:50) Sasha Levin wrote:

> On Fri, May 11, 2012 at 12:49 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> Fixes build error due to missing of_property_read_u32.
> >
> > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> > this missing header, it needs to have a Kconfig dependency that limits
> > it to just being enabled on the platforms where it physically is possible to
> > have the hardware.  I'm guessing limiting to ARM would be a good start?
> 
> I'm not sure how the actual hardware looks or even what it does, i
> just wanted to make sure that it doesn't break my x86 build. Which is
> why I'd rather not modify anything further than what I did in this
> patch.

Of course -- I was in the same boat.  I wasn't expecting you in
particular to add the Kconfig dependency, but rather instead I was
hoping someone who knows the platform details would make a proper one.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Grant Likely]

On Thu, May 10, 2012 at 4:49 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> Fixes build error due to missing of_property_read_u32.
>
> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> this missing header, it needs to have a Kconfig dependency that limits
> it to just being enabled on the platforms where it physically is possible to
> have the hardware.  I'm guessing limiting to ARM would be a good start?

IIRC, this hardware is available on x86.  Also, if CONFIG_OF is not
set, then the of_property_read_* functions compile out to do-nothing
stubs.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Peter Ujfalusi]

On 05/11/2012 07:27 AM, Grant Likely wrote:
> On Thu, May 10, 2012 at 4:49 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>>> Fixes build error due to missing of_property_read_u32.
>>
>> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
>> this missing header, it needs to have a Kconfig dependency that limits
>> it to just being enabled on the platforms where it physically is possible to
>> have the hardware.  I'm guessing limiting to ARM would be a good start?
> 
> IIRC, this hardware is available on x86.  Also, if CONFIG_OF is not
> set, then the of_property_read_* functions compile out to do-nothing
> stubs.

I had only linux/of_device.h included which would include of.h only if
CONFIG_OF_DEVICE is set.
Since the i386 did not had OF_DEVICE the of.h was not included (by
of_device.h) thus caused a build breakage.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Peter Ujfalusi]

Hi,

On 05/11/2012 01:49 AM, Paul Gortmaker wrote:
> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> Fixes build error due to missing of_property_read_u32.
> 
> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> this missing header, it needs to have a Kconfig dependency that limits
> it to just being enabled on the platforms where it physically is possible to
> have the hardware.  I'm guessing limiting to ARM would be a good start?

Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
won't happen again.


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Dmitry Torokhov]

On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote:
> Hi,
> 
> On 05/11/2012 01:49 AM, Paul Gortmaker wrote:
> > On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >> Fixes build error due to missing of_property_read_u32.
> > 
> > Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> > this missing header, it needs to have a Kconfig dependency that limits
> > it to just being enabled on the platforms where it physically is possible to
> > have the hardware.  I'm guessing limiting to ARM would be a good start?
> 
> Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
> If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
> won't happen again.

Is there any other errors beside missing include of.h (and extra
of_device.h?). The driver seems to be compiling fine on x86_64 so no
need to limit to ARM only...

Thanks.

-- 
Dmitry

Re: [PATCH] TWL6040: fix build error

[Paul Gortmaker]

On 12-05-11 03:20 AM, Dmitry Torokhov wrote:
> On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote:
>> Hi,
>>
>> On 05/11/2012 01:49 AM, Paul Gortmaker wrote:
>>> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>>>> Fixes build error due to missing of_property_read_u32.
>>>
>>> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
>>> this missing header, it needs to have a Kconfig dependency that limits
>>> it to just being enabled on the platforms where it physically is possible to
>>> have the hardware.  I'm guessing limiting to ARM would be a good start?
>>
>> Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
>> If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
>> won't happen again.
> 
> Is there any other errors beside missing include of.h (and extra
> of_device.h?). The driver seems to be compiling fine on x86_64 so no
> need to limit to ARM only...

Hi Dmitry,

It should be limited to the platforms where the hardware is available,
so that coverage builds aren't needlessly spending cycles building
stuff that can't possibly ever be used.  Also if it is limited to
ARM, then we can't have an ARM bug like this one mask the x86_64
allyesconfig build from uncovering possible errors that we really
care about seeing.

Thanks,
Paul.

> 
> Thanks.
> 

Re: [PATCH] TWL6040: fix build error

[Peter Ujfalusi]

Hi,

On 05/11/2012 05:03 PM, Paul Gortmaker wrote:
> Hi Dmitry,
> 
> It should be limited to the platforms where the hardware is available,
> so that coverage builds aren't needlessly spending cycles building
> stuff that can't possibly ever be used.  Also if it is limited to
> ARM, then we can't have an ARM bug like this one mask the x86_64
> allyesconfig build from uncovering possible errors that we really
> care about seeing.

The cleanest way to do this is to make the twl6040 MFD
(CONFIG_TWL6040_CORE) to depend on ARM (or on OMAP). That way none of
the drivers depending on it will got built on non ARM platforms.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] TWL6040: fix build error

[Dmitry Torokhov]

On Fri, May 11, 2012 at 10:03:36AM -0400, Paul Gortmaker wrote:
> On 12-05-11 03:20 AM, Dmitry Torokhov wrote:
> > On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote:
> >> Hi,
> >>
> >> On 05/11/2012 01:49 AM, Paul Gortmaker wrote:
> >>> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> >>>> Fixes build error due to missing of_property_read_u32.
> >>>
> >>> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> >>> this missing header, it needs to have a Kconfig dependency that limits
> >>> it to just being enabled on the platforms where it physically is possible to
> >>> have the hardware.  I'm guessing limiting to ARM would be a good start?
> >>
> >> Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
> >> If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
> >> won't happen again.
> > 
> > Is there any other errors beside missing include of.h (and extra
> > of_device.h?). The driver seems to be compiling fine on x86_64 so no
> > need to limit to ARM only...
> 
> Hi Dmitry,
> 
> It should be limited to the platforms where the hardware is available,
> so that coverage builds aren't needlessly spending cycles building
> stuff that can't possibly ever be used.  Also if it is limited to
> ARM, then we can't have an ARM bug like this one mask the x86_64
> allyesconfig build from uncovering possible errors that we really
> care about seeing.

Hi Paul,

I strongly disagree. The bug that we are talking about was not an
arch-specific bug; it eventually would have shown up on ARM with a
randconfig as well. So it is a _good_ thing that the build was not
limited just to ARM so that the bug got noticed early and fixed after
being present in -next for about a day.

So please do not add any additional constraints; better compile coverage
is a good thing.

Thanks.

-- 
Dmitry

Re: [PATCH] TWL6040: fix build error

[Paul Gortmaker]

On 12-05-11 11:49 AM, Dmitry Torokhov wrote:
> On Fri, May 11, 2012 at 10:03:36AM -0400, Paul Gortmaker wrote:
>> On 12-05-11 03:20 AM, Dmitry Torokhov wrote:
>>> On Fri, May 11, 2012 at 10:03:51AM +0300, Peter Ujfalusi wrote:
>>>> Hi,
>>>>
>>>> On 05/11/2012 01:49 AM, Paul Gortmaker wrote:
>>>>> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>>>>>> Fixes build error due to missing of_property_read_u32.
>>>>>
>>>>> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
>>>>> this missing header, it needs to have a Kconfig dependency that limits
>>>>> it to just being enabled on the platforms where it physically is possible to
>>>>> have the hardware.  I'm guessing limiting to ARM would be a good start?
>>>>
>>>> Yes it is only usable on ARM, most specifically on OMAP4+ platforms.
>>>> If I make the twl6040 MFD core to depend on ARM (or even on OMAP) this
>>>> won't happen again.
>>>
>>> Is there any other errors beside missing include of.h (and extra
>>> of_device.h?). The driver seems to be compiling fine on x86_64 so no
>>> need to limit to ARM only...
>>
>> Hi Dmitry,
>>
>> It should be limited to the platforms where the hardware is available,
>> so that coverage builds aren't needlessly spending cycles building
>> stuff that can't possibly ever be used.  Also if it is limited to
>> ARM, then we can't have an ARM bug like this one mask the x86_64
>> allyesconfig build from uncovering possible errors that we really
>> care about seeing.
> 
> Hi Paul,
> 
> I strongly disagree. The bug that we are talking about was not an
> arch-specific bug; it eventually would have shown up on ARM with a
> randconfig as well. So it is a _good_ thing that the build was not
> limited just to ARM so that the bug got noticed early and fixed after
> being present in -next for about a day.

I guess we'll have to agree to disagree then.  Regardless of whether
this instance coincidentally helped shine a light on some issue,
having arch specific _drivers_ built on the arch where they can never
be used makes no sense to me.  We don't try and build sparc specific
drivers on mips or vice versa.  So we shouldn't build ARM specific
code on x86 either.

Paul.
> 
> So please do not add any additional constraints; better compile coverage
> is a good thing.
> 
> Thanks.
> 

Re: [PATCH] TWL6040: fix build error

[Mark Brown]

On Thu, May 10, 2012 at 06:49:16PM -0400, Paul Gortmaker wrote:
> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> > Fixes build error due to missing of_property_read_u32.

> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
> this missing header, it needs to have a Kconfig dependency that limits
> it to just being enabled on the platforms where it physically is possible to
> have the hardware.  I'm guessing limiting to ARM would be a good start?

Half the idea is to get better test coverage and help people who want to
do things like build test API updates - the more systems the driver can
be built on the better from that point of view.

Re: [PATCH] TWL6040: fix build error

[Dmitry Torokhov]

Hi Sasha,

On Thu, May 10, 2012 at 08:44:33PM +0200, Sasha Levin wrote:
> Fixes build error due to missing of_property_read_u32.
> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  drivers/input/misc/twl6040-vibra.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
> index bb134ce..97447ee 100644
> --- a/drivers/input/misc/twl6040-vibra.c
> +++ b/drivers/input/misc/twl6040-vibra.c
> @@ -27,6 +27,7 @@
>   */
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
> +#include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/workqueue.h>
>  #include <linux/input.h>

Thank you for the fix; I folded it into original patch to avoid bisection
troubles.

-- 
Dmitry

Re: [PATCH] TWL6040: fix build error

[Peter Ujfalusi]

Hi,

On 05/10/2012 09:44 PM, Sasha Levin wrote:
> Fixes build error due to missing of_property_read_u32.

The reason I have not seen this is that I have CONFIG_OF_DEVICE selected
which will make the linux/of.h to be included in the linux/of_device.h

When I did sanity build check on x86 (64bit) I have not noticed any
breakage since the allmodconfig on 64bit does not build the
twl6040-vibra driver.

It is obvious that I need to improve my sanity kernel build testing.

> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>