linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: sonic.zhang@analog.com
Cc: linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [PATCH] input: rotary: Init wake according to platform pm_wakeup flag.
Date: Wed, 16 May 2012 11:30:39 -0700	[thread overview]
Message-ID: <20120516183038.GA14471@core.coreip.homeip.net> (raw)
In-Reply-To: <1337157383-13631-1-git-send-email-sonic.zhang@analog.com>

Hi Sonic,

On Wed, May 16, 2012 at 04:36:23PM +0800, sonic.zhang@analog.com wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> Rotary can't be used as a wakeup source in all Blackfin processors.
> 
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> ---
>  drivers/input/misc/bfin_rotary.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/misc/bfin_rotary.c b/drivers/input/misc/bfin_rotary.c
> index 1c4146f..bb1971c 100644
> --- a/drivers/input/misc/bfin_rotary.c
> +++ b/drivers/input/misc/bfin_rotary.c
> @@ -182,7 +182,7 @@ static int __devinit bfin_rotary_probe(struct platform_device *pdev)
>  	bfin_write_CNT_CONFIG(bfin_read_CNT_CONFIG() | CNTE);
>  
>  	platform_set_drvdata(pdev, rotary);
> -	device_init_wakeup(&pdev->dev, 1);
> +	device_init_wakeup(&pdev->dev, pdata->pm_wakeup);

I do not see pm_wakeup in bfin_rotary_platform_data.

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-05-16 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16  8:36 [PATCH] input: rotary: Init wake according to platform pm_wakeup flag sonic.zhang
2012-05-16 18:30 ` Dmitry Torokhov [this message]
2012-05-17  2:58   ` Zhang, Sonic
2012-05-17  6:08     ` Dmitry Torokhov
2012-05-17  6:32       ` Zhang, Sonic
2012-05-17  6:51         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120516183038.GA14471@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sonic.zhang@analog.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).