From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: viresh kumar <viresh.linux@gmail.com>
Cc: Viresh Kumar <viresh.kumar@st.com>,
swarren@nvidia.com, spear-devel@list.st.com,
devicetree-discuss@lists.ozlabs.org, olof@lixom.net,
linux-input@vger.kernel.org, sr@denx.de
Subject: Re: [PATCH V3 2/2] Input: spear-keyboard: add device tree bindings
Date: Thu, 17 May 2012 14:31:46 -0700 [thread overview]
Message-ID: <20120517213145.GB29141@core.coreip.homeip.net> (raw)
In-Reply-To: <CAOh2x=k2bZy-FV9XUWUxDaB7hCi1mfYv9tFVTnGObiAVjfOpvQ@mail.gmail.com>
On Tue, May 15, 2012 at 12:24:11PM +0530, viresh kumar wrote:
> Hi Dmitry,
>
> On Wed, May 9, 2012 at 10:58 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > Now that I got matrix_keypad_build_keymap() also handle DT case, how
> > about the patch below?
> >
> > Input: spear-keyboard - add device tree bindings
> >
> > From: Viresh Kumar <viresh.kumar@st.com>
> >
> > This adds simple DT bindings for spear-keyboard controller.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> > ---
> >
> > drivers/input/keyboard/spear-keyboard.c | 71 ++++++++++++++++++++++++-------
> > 1 files changed, 56 insertions(+), 15 deletions(-)
>
> You missed following file in this patch, which was there in original patch.
>
> Documentation/devicetree/bindings/input/spear-keyboard.txt
Oh, yes, sorry about that - that is danges of stgit - if patch does not
import cleanly for some reason (local changes in the tree for example)
and I have to massage and apply the patch then new files are not added
to git automatically and I sometimes forget about them. I'll ressurect
the doc change.
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-17 21:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 8:33 [PATCH V3 0/2] Input: Add matrix_keypad_of_build_keymap() Viresh Kumar
2012-03-29 8:33 ` [PATCH V3 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap() Viresh Kumar
2012-03-29 15:44 ` Stephen Warren
2012-03-29 16:31 ` viresh kumar
2012-03-30 3:38 ` Viresh Kumar
2012-03-29 8:33 ` [PATCH V3 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
2012-05-09 5:28 ` Dmitry Torokhov
2012-05-09 6:53 ` Viresh Kumar
2012-05-15 6:54 ` viresh kumar
2012-05-17 21:31 ` Dmitry Torokhov [this message]
2012-03-30 3:33 ` [PATCH v4 1/2] Input: of_keymap: Introduce matrix_keypad_of_build_keymap() Viresh Kumar
2012-03-30 3:55 ` Viresh Kumar
2012-03-30 3:40 ` [PATCH V4 Resend " Viresh Kumar
2012-03-30 18:45 ` Stephen Warren
2012-04-02 3:33 ` Viresh Kumar
2012-04-02 4:01 ` [PATCH] fixup! " Viresh Kumar
2012-04-05 0:45 ` Dmitry Torokhov
2012-04-05 3:52 ` Viresh Kumar
2012-04-17 11:32 ` Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2012-03-27 5:38 [PATCH V2 1/2] " Viresh Kumar
[not found] ` <4aba6f2cd9f050f419660555bdb661915c1be9b1.1332826100.git.viresh.kumar-qxv4g6HH51o@public.gmane.org>
2012-03-28 9:54 ` [PATCH V3 2/2] Input: spear-keyboard: add device tree bindings Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517213145.GB29141@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-input@vger.kernel.org \
--cc=olof@lixom.net \
--cc=spear-devel@list.st.com \
--cc=sr@denx.de \
--cc=swarren@nvidia.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).