linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, jcbian@pixcir.com.cn, rydberg@euromail.se
Subject: Re: Reg. kernel crash while using pixcir touchscreen driver
Date: Thu, 24 May 2012 00:47:05 -0700	[thread overview]
Message-ID: <20120524074705.GA10562@core.coreip.homeip.net> (raw)
In-Reply-To: <CAK9yfHzGgYTSE7mJ1xmnCrZ-_eYxBvbZp-hQ8tSJ77=TLvFdvQ@mail.gmail.com>

Hi Sachin,

On Thu, May 24, 2012 at 11:20:01AM +0530, Sachin Kamat wrote:
> Hi,
> 
> I encountered a kernel crash while integrating Pixcir touchscreen
> driver with one of our hardware. The log is attached at the end of the
> mail (inline).
> 
> The following ISR code:
> 
> while (!tsdata->exiting) {
>         pixcir_ts_poscheck(tsdata);
> 
>         if (tsdata->chip->attb_read_val())
>               break;
> 
>         msleep(20);
> }
> 
> seems to run until the if condition is false. However, when it exits
> the loop (when the condition becomes true), it crashes saying "exiting
> task "irq/438-pixcir_" (1011) is an active IRQ thread".

It actually crashes earlier, in pixcir_ts_isr() itself. The message is
coming from do_exit() when ISR thread dies. Did you porvide
attb_read_val implementation?

> 
> I have 2 questions here:
> 1. Do we need such a loop and the if condition. In my case it worked
> with the isr just doing
> pixcir_ts_poscheck(tsdata);
> 
> 2. What exactly is expected by attb_read_val() function.

I believe it is supposed to indicate if touch is detected so we can keep
polling.

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-05-24  7:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24  5:50 Reg. kernel crash while using pixcir touchscreen driver Sachin Kamat
2012-05-24  7:47 ` Dmitry Torokhov [this message]
2012-05-24  8:11   ` Sachin Kamat
2012-05-24  8:22     ` Dmitry Torokhov
2012-05-24 10:05       ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524074705.GA10562@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=jcbian@pixcir.com.cn \
    --cc=linux-input@vger.kernel.org \
    --cc=rydberg@euromail.se \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).