From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [git pull] Input updates for 3.5-rc0 Date: Thu, 24 May 2012 14:38:13 -0700 Message-ID: <20120524213813.GA17452@core.coreip.homeip.net> References: <20120524083216.GD10562@core.coreip.homeip.net> <20120524180154.GA15036@core.coreip.homeip.net> <20120524195851.GA15306@core.coreip.homeip.net> <20120524203647.GA16024@core.coreip.homeip.net> <20120524205952.GA16621@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:41749 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965637Ab2EXViT (ORCPT ); Thu, 24 May 2012 17:38:19 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Linus Torvalds Cc: Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Thu, May 24, 2012 at 02:07:29PM -0700, Linus Torvalds wrote: > On Thu, May 24, 2012 at 1:59 PM, Dmitry Torokhov > wrote: > > > > I was concerned about the _next_ device (the one that will be created > > the moment I plug in the tablet back into the same port) having exact > > same name as the one that is half dead and clashing in sysfs and > > elsewhere. We used to have issues with this. > > Ok, that's certainly a valid concern. > > It's still - I think - really sad/wrong that the device name is then > so useless than the drivers end up basically not using it. I can see the desire for logging, it is just hard to come with good automatic way of doing this without burdening drivers, given that errors happen rarely in input core layer and in driver code we already have perfect device object to report against. Maybe dev_XXX() should report full sysfs path do the dveice? Still does not help with the fact that "driver" shown for class devices is not so interesting as it will always be the class name. -- Dmitry