linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-input@vger.kernel.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: [PATCH] input: gpio_keys: added setup call for extending functionality of driver
Date: Thu, 21 Jun 2012 01:50:45 -0700	[thread overview]
Message-ID: <20120621085045.GD2193@core.coreip.homeip.net> (raw)
In-Reply-To: <1340208597-31865-1-git-send-email-shc_work@mail.ru>

Hi Alexander,

On Wed, Jun 20, 2012 at 08:09:57PM +0400, Alexander Shiyan wrote:
> This additional call can be used for extending functionality of
> driver. For example we can add EV_SND, EV_LED, etc. handlers.
> 

I am not sure that gpio_keys is quite ready to handle events besides
EV_KEY and EV_SW, additional changes are needed; and if you make those
additional changes then I think current platform data should be
sufficient to specify all supported even types.

Also, given the general push towards DT-ased setups platform-supplied
board setup code might not be the best approach.

Thanks.

-- 
Dmitry

  reply	other threads:[~2012-06-21  8:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-20 16:09 [PATCH] input: gpio_keys: added setup call for extending functionality of driver Alexander Shiyan
2012-06-21  8:50 ` Dmitry Torokhov [this message]
2012-06-21 10:03   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120621085045.GD2193@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-input@vger.kernel.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).