From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Fabien Marteau <fabien.marteau@armadeus.com>,
HeungJun Kim <riverful.kim@samsung.com>,
Zhang Jiejing <jiejing.zhang@freescale.com>,
Bo Shen <voice.shen@atmel.com>, Sriramakrishnan <srk@ti.com>,
Kyle Manna <kyle.manna@fuel7.com>,
Cyril Chemparathy <cyril@ti.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>,
Alan Cox <alan@linux.intel.com>,
Jianchun Bian <jcbian@pixcir.com.cn>,
Aaro Koskinen <aaro.koskinen@nokia.com>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] input: Request threaded-only IRQs with IRQF_ONESHOT
Date: Mon, 2 Jul 2012 12:04:02 -0700 [thread overview]
Message-ID: <20120702190402.GA16271@core.coreip.homeip.net> (raw)
In-Reply-To: <1341229460-23732-1-git-send-email-lars@metafoo.de>
H Lars, Thomas,
On Mon, Jul 02, 2012 at 01:44:20PM +0200, Lars-Peter Clausen wrote:
> Since commit 1c6c69525b ("genirq: Reject bogus threaded irq requests") threaded
> IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise
> the request will fail. This patch adds the IRQF_ONESHOT to IIO drivers where it
> is missing. Not modified by this patch are those drivers where the requested IRQ
> will always be a nested IRQ (e.g. because it's part of an MFD), since for this
> special case IRQF_ONESHOT is not required to be specified when requesting the
> IRQ.
This is not very helpful. Why, instead of bailing out, genirq case does
not add IRQF_ONESHOT itself to the flags? Then we would not need to
alter zillions of drivers.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-07-02 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 11:44 [PATCH] input: Request threaded-only IRQs with IRQF_ONESHOT Lars-Peter Clausen
2012-07-02 11:50 ` Lars-Peter Clausen
2012-07-02 19:04 ` Dmitry Torokhov [this message]
2012-07-02 19:11 ` Thomas Gleixner
2012-07-02 19:21 ` Linus Torvalds
2012-07-02 19:22 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120702190402.GA16271@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=aaro.koskinen@nokia.com \
--cc=alan@linux.intel.com \
--cc=cyril@ti.com \
--cc=fabien.marteau@armadeus.com \
--cc=jcbian@pixcir.com.cn \
--cc=jiejing.zhang@freescale.com \
--cc=jy0922.shim@samsung.com \
--cc=kyle.manna@fuel7.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=naveen.gaddipati@stericsson.com \
--cc=riverful.kim@samsung.com \
--cc=srk@ti.com \
--cc=tglx@linutronix.de \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).