From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad Date: Fri, 6 Jul 2012 10:03:50 -0700 Message-ID: <20120706170350.GA9909@core.coreip.homeip.net> References: <1341592324-665-1-git-send-email-yurivkhan@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:53824 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116Ab2GFRD5 (ORCPT ); Fri, 6 Jul 2012 13:03:57 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Yuri Khan Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org On Fri, Jul 06, 2012 at 11:57:44PM +0700, Yuri Khan wrote: > On Fri, Jul 6, 2012 at 11:32 PM, Yuri Khan wrote: > > > When I add a usbhid option quirks=0x0738:0x4540:0x4 (so that usbhid does > > not attempt to handle this device) and rebuild the xpad module with the > > following patch, the device works as expected. Dmitry Torokhov, the > > current maintainer of input drivers, suggested that I include a change > > to add the usbhid quirk in my patch. > > Of course the good idea only ever comes after the fact. If I change > usbhid to ignore this vendor:device unconditionally, then xpad should > also always handle it regardless of interface class/subclass/protocol, > right? Yes. -- Dmitry