From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bob Ross <pigiron@gmx.com>
Cc: Jan Steinhoff <mail@jan-steinhoff.de>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] synaptics_usb: Remove TrackPoint name trailing whitespace
Date: Sat, 7 Jul 2012 17:52:20 -0700 [thread overview]
Message-ID: <20120708005220.GB19007@core.coreip.homeip.net> (raw)
In-Reply-To: <20120706122817.4ff2cdbf@atom.pigiron.org>
On Fri, Jul 06, 2012 at 12:28:17PM -0500, Bob Ross wrote:
>
> The USB TrackPoint name string contains a space at the trailing end that
> can cause confusion/difficulty when creating udev rules. Example:
>
> "Synaptics Inc. Composite TouchPad / TrackPoint (Stick) "
>
> This patch removes the trailing space.
>
> Signed-off-by: Bob Ross <pigiron@gmx.com>
Applied, thank you Bob.
> ---
> This patch was based from the "torvalds" git tree.
>
> drivers/input/mouse/synaptics_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics_usb.c b/drivers/input/mouse/synaptics_usb.c
> index 3c5eaaa..64cf34e 100644
> --- a/drivers/input/mouse/synaptics_usb.c
> +++ b/drivers/input/mouse/synaptics_usb.c
> @@ -364,7 +364,7 @@ static int synusb_probe(struct usb_interface *intf,
> le16_to_cpu(udev->descriptor.idProduct));
>
> if (synusb->flags & SYNUSB_STICK)
> - strlcat(synusb->name, " (Stick) ", sizeof(synusb->name));
> + strlcat(synusb->name, " (Stick)", sizeof(synusb->name));
>
> usb_make_path(udev, synusb->phys, sizeof(synusb->phys));
> strlcat(synusb->phys, "/input0", sizeof(synusb->phys));
> --
> 1.7.11
>
--
Dmitry
prev parent reply other threads:[~2012-07-08 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 17:28 [PATCH] synaptics_usb: Remove TrackPoint name trailing whitespace Bob Ross
2012-07-08 0:52 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120708005220.GB19007@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@jan-steinhoff.de \
--cc=pigiron@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).