linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH v4] Input: synaptics - handle out of bounds values from the hardware
Date: Wed, 25 Jul 2012 08:47:18 -0500	[thread overview]
Message-ID: <20120725134718.GA5687@thinkpad-t410> (raw)
In-Reply-To: <CAGS+omAJD9CH-1fbiWae6SDiXMaz+b09TG9wusNmD5Q_SGBLFg@mail.gmail.com>

On Wed, Jul 25, 2012 at 10:50:15AM +0800, Daniel Kurtz wrote:
> > +       /* Convert wrap-around values to negative */
> > +       if (hw->x > X_MAX_POSITIVE)
> > +               hw->x = hw->x - (1 << ABS_POS_BITS);
> 
> Hi Seth,
> 
> Perhaps:
> hw->x -= (1 << ABS_POS_BITS);

It makes no difference to me, either way it works the same. I don't
think I'll send another patch just to change this though, unless Dmitry
asks for it :)

> Either way, it looks good, thanks!
> 
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>

Thanks!

Seth

      reply	other threads:[~2012-07-25 13:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-29 18:22 [PATCH v3] Input: synaptics - handle out of bounds values from the hardware Seth Forshee
2012-07-16 22:18 ` Seth Forshee
2012-07-17  2:21 ` Daniel Kurtz
2012-07-24 19:31   ` [PATCH v4] " Seth Forshee
2012-07-25  2:50     ` Daniel Kurtz
2012-07-25 13:47       ` Seth Forshee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120725134718.GA5687@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=djkurtz@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).