From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benson Leung <bleung@chromium.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup
Date: Sun, 29 Jul 2012 22:50:09 -0700 [thread overview]
Message-ID: <20120730055009.GB5830@core.coreip.homeip.net> (raw)
In-Reply-To: <1343283113-16952-1-git-send-email-bleung@chromium.org>
Hi Benson,
On Wed, Jul 25, 2012 at 11:11:53PM -0700, Benson Leung wrote:
> If a button is configured to wake the system, report a pm wakeup event.
>
Thank you for your patch, however I applied more complete patch sent by
NeilBrown.
> Signed-off-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/input/keyboard/gpio_keys.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index cbb1add..15a80e2 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -328,9 +328,13 @@ static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata)
> {
> const struct gpio_keys_button *button = bdata->button;
> struct input_dev *input = bdata->input;
> + struct device *dev = input->dev.parent;
> unsigned int type = button->type ?: EV_KEY;
> int state = (gpio_get_value_cansleep(button->gpio) ? 1 : 0) ^ button->active_low;
>
> + if (button->wakeup && device_may_wakeup(dev))
> + pm_wakeup_event(dev, 0);
> +
> if (type == EV_ABS) {
> if (state)
> input_event(input, type, button->code, button->value);
> --
> 1.7.7.3
>
--
Dmitry
next prev parent reply other threads:[~2012-07-30 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 6:11 [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup Benson Leung
2012-07-30 5:50 ` Dmitry Torokhov [this message]
2012-07-30 19:28 ` Benson Leung
2012-07-30 19:50 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730055009.GB5830@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).