From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linus.walleij@stericsson.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
Date: Mon, 6 Aug 2012 18:24:07 +0100 [thread overview]
Message-ID: <20120806172406.GC31409@gmail.com> (raw)
In-Reply-To: <20120806160226.GF29272@sirena.org.uk>
On Mon, Aug 06, 2012 at 05:02:26PM +0100, Mark Brown wrote:
> On Mon, Aug 06, 2012 at 04:37:52PM +0100, Lee Jones wrote:
> > On Mon, Aug 06, 2012 at 01:19:15AM -0700, Dmitry Torokhov wrote:
>
> > > > + ponkey->irq_dbf = (np) ? ab8500_irq_get_virq(ab8500, irq_dbf) : irq_dbf;
> > > > + ponkey->irq_dbr = (np) ? ab8500_irq_get_virq(ab8500, irq_dbr) : irq_dbr;
>
> > > Why this isn't done inside ab8500_irq_get_virq()?
>
> > There's no reason why it can't be.
>
> > My first version of the patch did just that in fact.
>
> > Would that be your preference?
>
> Restating my comment elsewhere... why do we even need to do this in
> _get_virq() - I'd *really* expect this to be handled by the irq domain
> code.
I really should stop reading my emails backwards. :)
I'll look into this tomorrow.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-08-06 17:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 12:32 [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Lee Jones
2012-08-06 8:19 ` Dmitry Torokhov
2012-08-06 15:37 ` Lee Jones
2012-08-06 16:02 ` Mark Brown
2012-08-06 17:24 ` Lee Jones [this message]
2012-08-07 17:01 ` Lee Jones
2012-08-07 17:03 ` Mark Brown
2012-08-08 7:35 ` Lee Jones
2012-08-08 8:04 ` Lee Jones
2012-08-08 8:28 ` Arnd Bergmann
2012-08-08 9:59 ` Mark Brown
2012-08-08 9:49 ` Mark Brown
2012-08-08 11:40 ` Lee Jones
2012-08-08 13:17 ` Mark Brown
2012-09-13 9:35 ` Linus Walleij
2012-09-14 8:03 ` Lee Jones
2012-09-18 11:22 ` Linus Walleij
2012-09-19 17:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120806172406.GC31409@gmail.com \
--to=lee.jones@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).