From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Date: Wed, 8 Aug 2012 14:17:14 +0100 Message-ID: <20120808131714.GT16861@opensource.wolfsonmicro.com> References: <20120807170333.GV16861@opensource.wolfsonmicro.com> <20120808080411.GB4728@gmail.com> <20120808094952.GH16861@opensource.wolfsonmicro.com> <20120808114037.GB8227@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from opensource.wolfsonmicro.com ([80.75.67.52]:52117 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758127Ab2HHNRQ (ORCPT ); Wed, 8 Aug 2012 09:17:16 -0400 Content-Disposition: inline In-Reply-To: <20120808114037.GB8227@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Lee Jones Cc: Dmitry Torokhov , linus.walleij@stericsson.com, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linux-arm-kernel@lists.infradead.org On Wed, Aug 08, 2012 at 12:40:38PM +0100, Lee Jones wrote: > On Wed, Aug 08, 2012 at 10:49:52AM +0100, Mark Brown wrote: > > > - MFD adds the IRQ base to the hwirq and registers it as a virq > > Just don't do this step - the only reason to do it is for mapping back > > into a linear domain but if you're going to do this... > > > - AB8500 child devices use *_get_virq() to convert virq to virq - *ERROR* > > ...then it's redundant. The mapping functions in the domain code > > replace this functionality. > No, the other way round. This is now required all the time. > Now we force the use of hwirq, the driver needs to convert that into a > virq before requesting the resource. So we need to put *_get_virq()'s into > every child device that requests an IRQ. Yes, that's exactly what I said - and as a result of doing this the remapping in the MFD core becomes redundant.