From: Dan Carpenter <dan.carpenter@oracle.com>
To: rydberg@euromail.se
Cc: linux-input@vger.kernel.org
Subject: re: HID: hid-multitouch: Switch to device groups
Date: Wed, 8 Aug 2012 16:44:08 +0300 [thread overview]
Message-ID: <20120808134408.GA25857@elgon.mountain> (raw)
Hello Henrik Rydberg,
This is a semi-automatic email about new static checker warnings.
The patch 4fa3a5837b84: "HID: hid-multitouch: Switch to device
groups" from May 1, 2012, leads to the following Smatch complaint:
drivers/hid/hid-multitouch.c:735 mt_probe()
error: we previously assumed 'id' could be null (see line 694)
drivers/hid/hid-multitouch.c
693
694 if (id) {
^^^^
Old check.
695 for (i = 0; mt_classes[i].name ; i++) {
696 if (id->driver_data == mt_classes[i].name) {
697 mtclass = &(mt_classes[i]);
698 break;
699 }
700 }
701 }
702
[snip]
733 mt_post_parse(td);
734
735 if (id->vendor == HID_ANY_ID && id->product == HID_ANY_ID)
^^^^^^^^^^
New dereference removed a check.
736 mt_post_parse_default_settings(td);
737
regards,
dan carpenter
next reply other threads:[~2012-08-08 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 13:44 Dan Carpenter [this message]
2012-08-08 17:28 ` HID: hid-multitouch: Switch to device groups Henrik Rydberg
2012-08-08 18:07 ` Dan Carpenter
2012-08-08 19:54 ` Henrik Rydberg
2012-08-15 8:38 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808134408.GA25857@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).