From: Dan Carpenter <dan.carpenter@oracle.com>
To: arnd@arndb.de
Cc: linux-input@vger.kernel.org
Subject: re: Input: eeti_ts: pass gpio value instead of IRQ
Date: Fri, 10 Aug 2012 15:25:25 +0300 [thread overview]
Message-ID: <20120810122525.GA22941@elgon.mountain> (raw)
Hello Arnd Bergmann,
This is a semi-automatic email about new static checker warnings.
The patch 4eef6cbfcc03: "Input: eeti_ts: pass gpio value instead of
IRQ" from Apr 30, 2012, leads to the following Smatch complaint:
drivers/input/touchscreen/eeti_ts.c:209 eeti_ts_probe()
warn: variable dereferenced before check 'pdata' (see line 202)
drivers/input/touchscreen/eeti_ts.c
201 priv->input = input;
202 priv->irq_gpio = pdata->irq_gpio;
^^^^^^^^^^^^^^^
203 priv->irq = gpio_to_irq(pdata->irq_gpio);
^^^^^^^^^^^^^^^
204
205 err = gpio_request_one(pdata->irq_gpio, GPIOF_IN, client->name);
^^^^^^^^^^^^^^^
New dereferences.
206 if (err < 0)
207 goto err1;
208
209 if (pdata)
^^^^^
Old check.
210 priv->irq_active_high = pdata->irq_active_high;
211
regards,
dan carpenter
reply other threads:[~2012-08-10 12:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120810122525.GA22941@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).