linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Henrik Rydberg <rydberg@euromail.se>
Subject: Re: USB interrupt times
Date: Wed, 15 Aug 2012 10:15:54 +0100	[thread overview]
Message-ID: <20120815091554.GD7105@flint.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LNX.2.00.1208151102040.7026@pobox.suse.cz>

On Wed, Aug 15, 2012 at 11:02:37AM +0200, Jiri Kosina wrote:
> On Tue, 14 Aug 2012, Russell King wrote:
> 
> > > Actually, Henrik (added to CC) has been doing some latency improvements 
> > > both for input core in general, and for HID devices as well lately. I 
> > > still have his patchset in my to-review queue, as I have just came back 
> > > from offline vacation, but the patch below definitely can't hurt and 
> > > should significantly lower the time spent in handling the irq for hid 
> > > device in common situation (i.e. noone listening for debugfs events).
> > > 
> > > Could you please measure how much it helps on your system?
> > 
> > Ok, it looks like it's changed the maximum USB interrupt execution
> > time from around 364us to 255us.
> > 
> > If I also do a similar trick with the debug code in hid_input_report()
> > then I get down to 212us - iow, something like the patch below.
> 
> Are you testing with kernel that contains b94e3c94aae04 already? That 
> should cover that case.

No - the kernel I'm dealing with is unfortunately based upon v3.5.0-rc5
with many other patches on top (which add support for this platform.)
However, I'll pick that commit into this tree.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

  reply	other threads:[~2012-08-15  9:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 10:39 USB interrupt times Russell King
2012-08-14 10:54 ` Jiri Kosina
     [not found]   ` <alpine.LNX.2.00.1208141250020.12490-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2012-08-14 12:18     ` Russell King
     [not found]       ` <20120814121804.GC7105-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-08-14 18:30         ` Henrik Rydberg
2012-08-15  9:02       ` Jiri Kosina
2012-08-15  9:15         ` Russell King [this message]
2012-08-14 12:31   ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120815091554.GD7105@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).