linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@bitmath.se>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Simon Farnsworth <simon.farnsworth@onelan.co.uk>,
	linux-input@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@enac.fr>,
	Henrik Rydberg <rydberg@bitmath.se>
Subject: Re: [PATCH] hid: Remove QUANTA from special drivers list
Date: Wed, 22 Aug 2012 19:00:52 +0200	[thread overview]
Message-ID: <20120822170052.GA6158@polaris.bitmath.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1208221648130.32304@pobox.suse.cz>

> > Applying just this patch is enough to fix the problem I described in my mail
> > "QUANTA touchscreen controller integrated in HP2310ti no longer recognised
> > (regression in 3.5 and later as compared to 3.3)".
> > 
> > This looks like an oversight in commit 4fa3a58; that commit removes most
> > multitouch screens from this list, but missed this one. Henrik should be
> > able to confirm, though, so I'd appreciate his sign-off.

Yes, good find. We have two identifiers for the same device,
USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN and
USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001, which might explain why it
was overlooked. I think we should get rid of one of them. Also, I
wonder if the HID_QUIRK_NOGET quirk is still necessary.

Thanks,
Henrik

  reply	other threads:[~2012-08-22 16:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 10:17 [PATCH] hid: Remove QUANTA from special drivers list Simon Farnsworth
2012-08-22 14:48 ` Jiri Kosina
2012-08-22 17:00   ` Henrik Rydberg [this message]
2012-08-23 10:10     ` Simon Farnsworth
2012-08-23 16:48       ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120822170052.GA6158@polaris.bitmath.org \
    --to=rydberg@bitmath.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=benjamin.tissoires@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=simon.farnsworth@onelan.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).