From: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
lm-sensors@lm-sensors.org, linux-input@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-leds@vger.kernel.org,
"Samuel Ortiz" <sameo@linux.intel.com>,
"Liam Girdwood" <lrg@ti.com>,
"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Jean Delvare" <khali@linux-fr.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Ashish Jangam" <ashish.jangam@kpitcummins.com>,
"Andrew Jones" <drjones@redhat.com>,
"Donggeun Kim" <dg77.kim@samsung.com>,
"Philippe Rétornaz" <philippe.retornaz@epfl.ch>,
"Wim Van Sebroeck" <wim@iguana.be>,
"Bryan Wu" <bryan.wu@canonical.com>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Anthony Olech" <anthony.olech@diasemi.com>
Subject: Re: [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support.
Date: Fri, 31 Aug 2012 11:00:00 +0100 [thread overview]
Message-ID: <201208311100@sw-eng-lt-dc-vm2> (raw)
In-Reply-To: <20120830174738.GH4356@opensource.wolfsonmicro.com>
> On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote:
>
> > Because, for some regulators, this is required: val += fvol->offset,
> > I was only able to reduce it to the following form.
>
> What on earth makes you say this? The above is obviously linear.
>
> Besides, you're missing several points here. One is that you should be
> using the framework features, another is that you should be implementing
> _sel.
Sorry, I've missed an obvious thing here. Instead of adding selector offset at
runtime, I can substract apropriate voltage from .min_uV. Thanks for pointing
this out.
next prev parent reply other threads:[~2012-08-31 10:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 13:45 [RFC PATCH 0/8] DA906x PMIC driver Krystian Garbaciak
2012-08-24 13:50 ` [PATCH 1/8] mfd: Add Dialog DA906x core driver Krystian Garbaciak
2012-08-24 13:55 ` [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support Krystian Garbaciak
2012-08-24 14:00 ` [RFC PATCH 3/8] rtc: Add RTC driver for DA906x PMIC Krystian Garbaciak
2012-08-24 14:05 ` [RFC PATCH 4/8] hwmon: Add DA906x hardware monitoring support Krystian Garbaciak
2012-08-24 14:10 ` [RFC PATCH 5/8] input: Add support for DA906x PMIC OnKey detection Krystian Garbaciak
2012-08-24 14:15 ` [RFC PATCH 6/8] input: Add support for DA906x vibration motor driver Krystian Garbaciak
2012-08-24 14:20 ` [RFC PATCH 7/8] watchdog: Add DA906x PMIC watchdog driver Krystian Garbaciak
2012-08-24 14:25 ` [RFC PATCH 8/8] leds: Add DA906x PMIC LED driver Krystian Garbaciak
2012-08-24 18:45 ` [RFC PATCH 4/8] hwmon: Add DA906x hardware monitoring support Guenter Roeck
2012-08-29 13:25 ` [PATCH] regulator: Fix bug in regulator_mode_to_status() core function Krystian Garbaciak
2012-08-25 15:10 ` [RFC PATCH 2/8] regulator: Add Dialog DA906x voltage regulators support Mark Brown
2012-08-29 14:50 ` Krystian Garbaciak
2012-08-30 17:47 ` Mark Brown
2012-08-31 10:00 ` Krystian Garbaciak [this message]
2012-08-25 18:31 ` [PATCH 1/8] mfd: Add Dialog DA906x core driver Mark Brown
2012-08-31 11:20 ` Krystian Garbaciak
2012-08-31 11:37 ` Philippe Rétornaz
2012-08-31 17:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208311100@sw-eng-lt-dc-vm2 \
--to=krystian.garbaciak@diasemi.com \
--cc=a.zummo@towertech.it \
--cc=anthony.olech@diasemi.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=bryan.wu@canonical.com \
--cc=dg77.kim@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=drjones@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=lrg@ti.com \
--cc=philippe.retornaz@epfl.ch \
--cc=rpurdie@rpsys.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).