linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Josh <joshua.taylor0@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue.
Date: Tue, 4 Sep 2012 23:11:42 -0700	[thread overview]
Message-ID: <20120905061142.GA31943@core.coreip.homeip.net> (raw)
In-Reply-To: <1345767621-27816-1-git-send-email-joshua.taylor0@gmail.com>

On Thu, Aug 23, 2012 at 08:20:21PM -0400, Josh wrote:
> Fixed spacing error on if statements and fixed tab error.
> Signed-off-by: Josh <joshua.taylor0@gmail.com>

Applied, thank you Josh.

> ---
>  drivers/input/keyboard/omap-keypad.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
> index a0222db..b03c5b9 100644
> --- a/drivers/input/keyboard/omap-keypad.c
> +++ b/drivers/input/keyboard/omap-keypad.c
> @@ -214,7 +214,7 @@ static void omap_kp_tasklet(unsigned long data)
>  	memcpy(keypad_state, new_state, sizeof(keypad_state));
>  
>  	if (key_down) {
> -                int delay = HZ / 20;
> +		int delay = HZ / 20;
>  		/* some key is pressed - keep irq disabled and use timer
>  		 * to poll the keypad */
>  		if (spurious)
> @@ -413,7 +413,7 @@ static int __devinit omap_kp_probe(struct platform_device *pdev)
>  	}
>  	return 0;
>  err5:
> -	for (i = irq_idx - 1; i >=0; i--)
> +	for (i = irq_idx - 1; i >= 0; i--)
>  		free_irq(row_gpios[i], omap_kp);
>  err4:
>  	input_unregister_device(omap_kp->input);
> @@ -421,10 +421,10 @@ err4:
>  err3:
>  	device_remove_file(&pdev->dev, &dev_attr_enable);
>  err2:
> -	for (i = row_idx - 1; i >=0; i--)
> +	for (i = row_idx - 1; i >= 0; i--)
>  		gpio_free(row_gpios[i]);
>  err1:
> -	for (i = col_idx - 1; i >=0; i--)
> +	for (i = col_idx - 1; i >= 0; i--)
>  		gpio_free(col_gpios[i]);
>  
>  	kfree(omap_kp);
> -- 
> 1.7.9.5
> 

-- 
Dmitry

      reply	other threads:[~2012-09-05  6:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  0:20 [PATCH] Input: keyboard: omap-keypad: Fixed coding style issue Josh
2012-09-05  6:11 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905061142.GA31943@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=joshua.taylor0@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).