From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: dmitry.torokhov@gmail.com, kernel@pengutronix.de,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: imx_keypad - Fix missing clk conversions
Date: Thu, 6 Sep 2012 09:26:48 +0200 [thread overview]
Message-ID: <20120906072648.GP26594@pengutronix.de> (raw)
In-Reply-To: <1346765081-30443-1-git-send-email-fabio.estevam@freescale.com>
On Tue, Sep 04, 2012 at 10:24:41AM -0300, Fabio Estevam wrote:
> commit (Input: imx_keypad - adapt the new kpp clock name) missed to update
> clk_enable/clk_disable from imx_keypad_probe().
>
> Fix it so that we do not get clk warnings at boot.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/input/keyboard/imx_keypad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c
> index ce68e36..cdc2526 100644
> --- a/drivers/input/keyboard/imx_keypad.c
> +++ b/drivers/input/keyboard/imx_keypad.c
> @@ -516,9 +516,9 @@ static int __devinit imx_keypad_probe(struct platform_device *pdev)
> input_set_drvdata(input_dev, keypad);
>
> /* Ensure that the keypad will stay dormant until opened */
> - clk_enable(keypad->clk);
> + clk_prepare_enable(keypad->clk);
> imx_keypad_inhibit(keypad);
> - clk_disable(keypad->clk);
> + clk_disable_unprepare(keypad->clk);
>
> error = request_irq(irq, imx_keypad_irq_handler, 0,
> pdev->name, keypad);
> --
> 1.7.9.5
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2012-09-06 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 13:24 [PATCH] Input: imx_keypad - Fix missing clk conversions Fabio Estevam
2012-09-06 7:26 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906072648.GP26594@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).