linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: imx_keypad - Fix missing clk conversions
@ 2012-09-04 13:24 Fabio Estevam
  2012-09-06  7:26 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2012-09-04 13:24 UTC (permalink / raw)
  To: dmitry.torokhov; +Cc: kernel, linux-input, Fabio Estevam

commit (Input: imx_keypad - adapt the new kpp clock name) missed to update
clk_enable/clk_disable from imx_keypad_probe().

Fix it so that we do not get clk warnings at boot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/input/keyboard/imx_keypad.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c
index ce68e36..cdc2526 100644
--- a/drivers/input/keyboard/imx_keypad.c
+++ b/drivers/input/keyboard/imx_keypad.c
@@ -516,9 +516,9 @@ static int __devinit imx_keypad_probe(struct platform_device *pdev)
 	input_set_drvdata(input_dev, keypad);
 
 	/* Ensure that the keypad will stay dormant until opened */
-	clk_enable(keypad->clk);
+	clk_prepare_enable(keypad->clk);
 	imx_keypad_inhibit(keypad);
-	clk_disable(keypad->clk);
+	clk_disable_unprepare(keypad->clk);
 
 	error = request_irq(irq, imx_keypad_irq_handler, 0,
 			    pdev->name, keypad);
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: imx_keypad - Fix missing clk conversions
  2012-09-04 13:24 [PATCH] Input: imx_keypad - Fix missing clk conversions Fabio Estevam
@ 2012-09-06  7:26 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2012-09-06  7:26 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: dmitry.torokhov, kernel, linux-input

On Tue, Sep 04, 2012 at 10:24:41AM -0300, Fabio Estevam wrote:
> commit (Input: imx_keypad - adapt the new kpp clock name) missed to update
> clk_enable/clk_disable from imx_keypad_probe().
> 
> Fix it so that we do not get clk warnings at boot.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>


> ---
>  drivers/input/keyboard/imx_keypad.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c
> index ce68e36..cdc2526 100644
> --- a/drivers/input/keyboard/imx_keypad.c
> +++ b/drivers/input/keyboard/imx_keypad.c
> @@ -516,9 +516,9 @@ static int __devinit imx_keypad_probe(struct platform_device *pdev)
>  	input_set_drvdata(input_dev, keypad);
>  
>  	/* Ensure that the keypad will stay dormant until opened */
> -	clk_enable(keypad->clk);
> +	clk_prepare_enable(keypad->clk);
>  	imx_keypad_inhibit(keypad);
> -	clk_disable(keypad->clk);
> +	clk_disable_unprepare(keypad->clk);
>  
>  	error = request_irq(irq, imx_keypad_irq_handler, 0,
>  			    pdev->name, keypad);
> -- 
> 1.7.9.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-06  7:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-04 13:24 [PATCH] Input: imx_keypad - Fix missing clk conversions Fabio Estevam
2012-09-06  7:26 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).