From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Emil Goode <emilgoode@gmail.com>
Cc: jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] HID: picoLCD: Remove use of deprecated function
Date: Thu, 6 Sep 2012 22:12:52 +0200 [thread overview]
Message-ID: <20120906221252.1402ba50@neptune.home> (raw)
In-Reply-To: <1346942780-8091-1-git-send-email-emilgoode@gmail.com>
On Thu, 06 September 2012 Emil Goode <emilgoode@gmail.com> wrote:
> The flush_delayed_work_sync function is deprecated,
> we can instead call flush_delayed_work directly.
>
> Sparse is giving a warning:
> drivers/hid/hid-picolcd_fb.c:611:2: warning:
> ‘flush_delayed_work_sync’ is deprecated
> (declared at include/linux/workqueue.h:454)
> [-Wdeprecated-declarations]
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
This matches a patch by Tejun a few weeks ago which was partially
skipped in -next due to merge conflict with code split in picoLCD.
See http://comments.gmane.org/gmane.linux.kernel.next/23740
For the sake of proper bisectability, this should go in after
Tejun's workqueue changes (if needed at all depending on how merge
happens during pull by Linus).
Bruno
> ---
> drivers/hid/hid-picolcd_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index 0008a51..eb00357 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -608,7 +608,7 @@ void picolcd_exit_framebuffer(struct picolcd_data *data)
> /* make sure there is no running update - thus that fbdata->picolcd
> * once obtained under lock is guaranteed not to get free() under
> * the feet of the deferred work */
> - flush_delayed_work_sync(&info->deferred_work);
> + flush_delayed_work(&info->deferred_work);
>
> data->fb_info = NULL;
> unregister_framebuffer(info);
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-06 20:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 14:46 [PATCH] HID: picoLCD: Remove use of deprecated function Emil Goode
2012-09-06 20:12 ` Bruno Prémont [this message]
2012-09-06 20:15 ` Tejun Heo
2012-09-07 13:11 ` Jiri Kosina
2012-10-01 22:18 ` Jiri Kosina
2012-10-02 5:51 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906221252.1402ba50@neptune.home \
--to=bonbons@linux-vserver.org \
--cc=emilgoode@gmail.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).