linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH] Input: synaptics - Adjust threshold for treating position values as negative
Date: Mon, 10 Sep 2012 16:44:26 -0500	[thread overview]
Message-ID: <20120910214426.GG17662@thinkpad-t410> (raw)
In-Reply-To: <5697296.C0n5qnnV7e@dtor-d630.eng.vmware.com>

On Mon, Sep 10, 2012 at 02:10:13PM -0700, Dmitry Torokhov wrote:
> On Monday, September 10, 2012 07:47:07 AM Seth Forshee wrote:
> > Commit c039450 (Input: synaptics - handle out of bounds values from the
> > hardware) caused any hardware reported values over 7167 to be treated as
> > a wrapped-around negative value. It turns out that some firmware uses
> > the value 8176 to indicate a finger near the edge of the touchpad whose
> > actual position cannot be determined. This value now gets treated as
> > negative, which can cause pointer jumps and broken edge scrolling on
> > these machines.
> > 
> > I only know of one touchpad which reports negative values, and this
> > hardware never reports any value lower than -8 (i.e. 8184). Moving the
> > threshold for treating a value as negative up to 8176 should work fine
> > then for any hardware we currently know about, and since we're dealing
> > with unspecified behavior it's probably the best we can do. The special
> > 8176 value is also likely to result in sudden jumps in position, so
> > let's also clamp this to the maximum speicified value for the axis.
> 
> It looks like there is another touchpad that got broken with that "out of 
> bounds" change, see:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=46371

Thanks for alerting me to the bug, I'll follow up on bugzilla.

Thanks,
Seth


      reply	other threads:[~2012-09-10 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 12:47 [PATCH] Input: synaptics - Adjust threshold for treating position values as negative Seth Forshee
     [not found] ` <CAGS+omA_bX6FEYP1CU7bD6_UUG3dkpyzbHu1iOQhRWpWpT2tuw@mail.gmail.com>
2012-09-10 14:29   ` Seth Forshee
2012-09-10 16:29     ` Daniel Kurtz
2012-09-10 21:10 ` Dmitry Torokhov
2012-09-10 21:44   ` Seth Forshee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120910214426.GG17662@thinkpad-t410 \
    --to=seth.forshee@canonical.com \
    --cc=djkurtz@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).