From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Cc: JJ Ding <dgdunix@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: gpio_keys_polled: fix dt pdata->nbuttons
Date: Wed, 12 Sep 2012 21:49:35 -0700 [thread overview]
Message-ID: <20120913044935.GA17105@core.coreip.homeip.net> (raw)
In-Reply-To: <1347485243-21173-1-git-send-email-aletes.xgr@gmail.com>
On Wed, Sep 12, 2012 at 06:27:23PM -0300, Alexandre Pereira da Silva wrote:
> pdata->nbuttons should be updated by the dt code.
>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Applied, thank you Alexandre.
> ---
> drivers/input/keyboard/gpio_keys_polled.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
> index 7908952..f2142de 100644
> --- a/drivers/input/keyboard/gpio_keys_polled.c
> +++ b/drivers/input/keyboard/gpio_keys_polled.c
> @@ -129,6 +129,7 @@ gpio_keys_polled_get_devtree_pdata(struct device *dev)
> }
>
> pdata->buttons = (struct gpio_keys_button *)(pdata + 1);
> + pdata->nbuttons = nbuttons;
>
> pdata->rep = !!of_get_property(node, "autorepeat", NULL);
> of_property_read_u32(node, "poll-interval", &pdata->poll_interval);
> --
> 1.7.10
>
--
Dmitry
prev parent reply other threads:[~2012-09-13 4:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 21:27 [PATCH] input: gpio_keys_polled: fix dt pdata->nbuttons Alexandre Pereira da Silva
2012-09-13 4:49 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913044935.GA17105@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=aletes.xgr@gmail.com \
--cc=dgdunix@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).