* [patch 2/2] HID: sensors: remove some unneeded checks
@ 2012-09-14 6:53 Dan Carpenter
2012-09-17 10:59 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2012-09-14 6:53 UTC (permalink / raw)
To: srinivas pandruvada; +Cc: Jiri Kosina, linux-input, kernel-janitors
"report_id" is unsigned so it's never less than zero. These checks can
be removed without any problem.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 0c93b10..22ec3c6 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -214,9 +214,6 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
int ret = 0;
- if (report_id < 0)
- return -EINVAL;
-
mutex_lock(&data->mutex);
report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
if (!report || (field_index >= report->maxfield)) {
@@ -241,9 +238,6 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
int ret = 0;
- if (report_id < 0)
- return -EINVAL;
-
mutex_lock(&data->mutex);
report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
if (!report || (field_index >= report->maxfield)) {
@@ -271,9 +265,6 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
struct hid_report *report;
int ret_val = 0;
- if (report_id < 0)
- return -EINVAL;
-
mutex_lock(&data->mutex);
memset(&data->pending, 0, sizeof(data->pending));
init_completion(&data->pending.ready);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch 2/2] HID: sensors: remove some unneeded checks
2012-09-14 6:53 [patch 2/2] HID: sensors: remove some unneeded checks Dan Carpenter
@ 2012-09-17 10:59 ` Jiri Kosina
2012-09-17 15:21 ` Pandruvada, Srinivas
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2012-09-17 10:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: srinivas pandruvada, linux-input, kernel-janitors,
Jonathan Cameron
On Fri, 14 Sep 2012, Dan Carpenter wrote:
> "report_id" is unsigned so it's never less than zero. These checks can
> be removed without any problem.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Adding Jonathan to CC as well. Thanks.
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 0c93b10..22ec3c6 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -214,9 +214,6 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
> int ret = 0;
>
> - if (report_id < 0)
> - return -EINVAL;
> -
> mutex_lock(&data->mutex);
> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
> if (!report || (field_index >= report->maxfield)) {
> @@ -241,9 +238,6 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
> int ret = 0;
>
> - if (report_id < 0)
> - return -EINVAL;
> -
> mutex_lock(&data->mutex);
> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
> if (!report || (field_index >= report->maxfield)) {
> @@ -271,9 +265,6 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
> struct hid_report *report;
> int ret_val = 0;
>
> - if (report_id < 0)
> - return -EINVAL;
> -
> mutex_lock(&data->mutex);
> memset(&data->pending, 0, sizeof(data->pending));
> init_completion(&data->pending.ready);
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [patch 2/2] HID: sensors: remove some unneeded checks
2012-09-17 10:59 ` Jiri Kosina
@ 2012-09-17 15:21 ` Pandruvada, Srinivas
2012-09-18 20:52 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Pandruvada, Srinivas @ 2012-09-17 15:21 UTC (permalink / raw)
To: Jiri Kosina, Dan Carpenter
Cc: linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
Jonathan Cameron
Tested this and it works.
-----Original Message-----
From: Jiri Kosina [mailto:jkosina@suse.cz]
Sent: Monday, September 17, 2012 4:00 AM
To: Dan Carpenter
Cc: Pandruvada, Srinivas; linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org; Jonathan Cameron
Subject: Re: [patch 2/2] HID: sensors: remove some unneeded checks
On Fri, 14 Sep 2012, Dan Carpenter wrote:
> "report_id" is unsigned so it's never less than zero. These checks
> can be removed without any problem.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Adding Jonathan to CC as well. Thanks.
>
> diff --git a/drivers/hid/hid-sensor-hub.c
> b/drivers/hid/hid-sensor-hub.c index 0c93b10..22ec3c6 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -214,9 +214,6 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
> int ret = 0;
>
> - if (report_id < 0)
> - return -EINVAL;
> -
> mutex_lock(&data->mutex);
> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
> if (!report || (field_index >= report->maxfield)) { @@ -241,9
> +238,6 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
> int ret = 0;
>
> - if (report_id < 0)
> - return -EINVAL;
> -
> mutex_lock(&data->mutex);
> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
> if (!report || (field_index >= report->maxfield)) { @@ -271,9
> +265,6 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
> struct hid_report *report;
> int ret_val = 0;
>
> - if (report_id < 0)
> - return -EINVAL;
> -
> mutex_lock(&data->mutex);
> memset(&data->pending, 0, sizeof(data->pending));
> init_completion(&data->pending.ready);
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 2/2] HID: sensors: remove some unneeded checks
2012-09-17 15:21 ` Pandruvada, Srinivas
@ 2012-09-18 20:52 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2012-09-18 20:52 UTC (permalink / raw)
To: Pandruvada, Srinivas
Cc: Jiri Kosina, Dan Carpenter, linux-input@vger.kernel.org,
kernel-janitors@vger.kernel.org
I've add these both to the togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
Will send onwards in a few days.
> Tested this and it works.
>
> -----Original Message-----
> From: Jiri Kosina [mailto:jkosina@suse.cz]
> Sent: Monday, September 17, 2012 4:00 AM
> To: Dan Carpenter
> Cc: Pandruvada, Srinivas; linux-input@vger.kernel.org; kernel-janitors@vger.kernel.org; Jonathan Cameron
> Subject: Re: [patch 2/2] HID: sensors: remove some unneeded checks
>
> On Fri, 14 Sep 2012, Dan Carpenter wrote:
>
>> "report_id" is unsigned so it's never less than zero. These checks
>> can be removed without any problem.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> Adding Jonathan to CC as well. Thanks.
>
>>
>> diff --git a/drivers/hid/hid-sensor-hub.c
>> b/drivers/hid/hid-sensor-hub.c index 0c93b10..22ec3c6 100644
>> --- a/drivers/hid/hid-sensor-hub.c
>> +++ b/drivers/hid/hid-sensor-hub.c
>> @@ -214,9 +214,6 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
>> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
>> int ret = 0;
>>
>> - if (report_id < 0)
>> - return -EINVAL;
>> -
>> mutex_lock(&data->mutex);
>> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
>> if (!report || (field_index >= report->maxfield)) { @@ -241,9
>> +238,6 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
>> struct sensor_hub_data *data = hid_get_drvdata(hsdev->hdev);
>> int ret = 0;
>>
>> - if (report_id < 0)
>> - return -EINVAL;
>> -
>> mutex_lock(&data->mutex);
>> report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
>> if (!report || (field_index >= report->maxfield)) { @@ -271,9
>> +265,6 @@ int sensor_hub_input_attr_get_raw_value(struct hid_sensor_hub_device *hsdev,
>> struct hid_report *report;
>> int ret_val = 0;
>>
>> - if (report_id < 0)
>> - return -EINVAL;
>> -
>> mutex_lock(&data->mutex);
>> memset(&data->pending, 0, sizeof(data->pending));
>> init_completion(&data->pending.ready);
>>
>
> --
> Jiri Kosina
> SUSE Labs
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-18 20:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 6:53 [patch 2/2] HID: sensors: remove some unneeded checks Dan Carpenter
2012-09-17 10:59 ` Jiri Kosina
2012-09-17 15:21 ` Pandruvada, Srinivas
2012-09-18 20:52 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).