From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Date: Fri, 14 Sep 2012 09:03:48 +0100 Message-ID: <20120914080347.GB3374@gmail.com> References: <1344256323-10484-1-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:62583 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755668Ab2INIDx (ORCPT ); Fri, 14 Sep 2012 04:03:53 -0400 Received: by eekc1 with SMTP id c1so2342438eek.19 for ; Fri, 14 Sep 2012 01:03:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Linus Walleij Cc: arnd@arndb.de, Dmitry Torokhov , arm@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, linux-input@vger.kernel.org On Thu, Sep 13, 2012 at 11:35:43AM +0200, Linus Walleij wrote: > On Mon, Aug 6, 2012 at 2:32 PM, Lee Jones wrot= e: >=20 > > If we're booting with Device Tree enabled, we want the IRQ numbers = to > > be taken and translated from the Device Tree binary. If not, they > > should be taken from the resource allocation defined in the AB8500 = MFD > > core driver. > > > > Tested-by: Linus Walleij > > Signed-off-by: Lee Jones >=20 > Not having this patch in v3.6-rcN gives the following boot noise (and > the key does not work): >=20 > ------------[ cut here ]------------ > WARNING: at /home/elinwal/linux-stericsson/kernel/irq/irqdomain.c:137 > irq_domain_legacy_revmap+0x20/0x48() > Modules linked in: > [] (unwind_backtrace+0x0/0xf8) from [] > (warn_slowpath_common+0x4c/0x64) > [] (warn_slowpath_common+0x4c/0x64) from [] > (warn_slowpath_null+0x1c/0x24) > [] (warn_slowpath_null+0x1c/0x24) from [] > (irq_domain_legacy_revmap+0x20/0x48) > [] (irq_domain_legacy_revmap+0x20/0x48) from [] > (ab8500_ponkey_probe+0xd0/0x1f8) > [] (ab8500_ponkey_probe+0xd0/0x1f8) from [] > (platform_drv_probe+0x14/0x18) > [] (platform_drv_probe+0x14/0x18) from [] > (driver_probe_device+0x78/0x208) > [] (driver_probe_device+0x78/0x208) from [] > (__driver_attach+0x8c/0x90) > [] (__driver_attach+0x8c/0x90) from [] > (bus_for_each_dev+0x50/0x7c) > [] (bus_for_each_dev+0x50/0x7c) from [] > (bus_add_driver+0x170/0x23c) > [] (bus_add_driver+0x170/0x23c) from [] > (driver_register+0x78/0x144) > [] (driver_register+0x78/0x144) from [] > (do_one_initcall+0x34/0x174) > [] (do_one_initcall+0x34/0x174) from [] > (kernel_init+0xfc/0x1bc) > [] (kernel_init+0xfc/0x1bc) from [] > (kernel_thread_exit+0x0/0x8) > ---[ end trace d77aa0db848f0e28 ]--- > ab8500-core ab8500-core.0: Failed to request dbf IRQ#0: -22 > ab8500-poweron-key: probe of ab8500-poweron-key.0 failed with error -= 22 >=20 > So how do we proceed to not release v3.6 with this regression? >=20 > Shall all of the MFD IRQdomain stuff be pulled into the -rc series? >=20 > (Linux-next seems to be working, so the real fix is in there) I haven't tested this, but I think this patch should be pulled out of -next and pushed into the -rcs to fix the issue you see above. The real fix along with the revert to this patch also resides in -next and will be applied during the next merge window. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html