From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Ashish Jangam <ashish.jangam@kpitcummins.com>,
Grant Likely <grant.likely@secretlab.ca>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-input@vger.kernel.org, David Dajun Chen <dchen@diasemi.com>
Subject: Re: [Patch v1 4/7] DA9055 GPIO driver
Date: Fri, 14 Sep 2012 17:38:54 +0100 [thread overview]
Message-ID: <20120914163854.GG4684@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACRpkdYQutaM2aHyJOmtYZtZ8w6c-pQ4xm5adUAia1UH-SM88Q@mail.gmail.com>
On Fri, Sep 14, 2012 at 04:13:57PM +0200, Linus Walleij wrote:
> But the parent driver is using regmap, sand you seem not to use the
> struct da9055
> for anything else than passing reads/writes, so isn't it simpler to just pass
> the struct regmap * and use update_bits etc directly and remove a layer of
> indirection?
> I'm very uncertain but Mark will know the proper design pattern.
Either way is fine - usually the device specific functions end up being
static inlines in the header so the code is the same. It really depends
if it's useful to have the full device pointer around for other things.
next prev parent reply other threads:[~2012-09-14 16:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 13:30 [Patch v1 4/7] DA9055 GPIO driver Ashish Jangam
2012-09-14 13:06 ` Laxman Dewangan
2012-09-14 14:13 ` Linus Walleij
2012-09-14 16:38 ` Mark Brown [this message]
2012-10-12 9:55 ` Ashish Jangam
2012-10-12 21:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914163854.GG4684@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).