From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] HID: picoLCD: off by one in dump_buff_as_hex()
Date: Sat, 22 Sep 2012 15:55:12 +0300 [thread overview]
Message-ID: <20120922125512.GG4587@mwanda> (raw)
In-Reply-To: <20120919213535.34712fb5@neptune.home>
On Wed, Sep 19, 2012 at 09:35:35PM +0200, Bruno Prémont wrote:
> Dan,
>
> What's your opinion on below alternative patch?
> In addition to yours it makes would-overflow visible.
>
> It does not check for output buffer having non-zero size but
> as callers are local with #defined buffer size I don't think that would
> be needed.
>
Sorry for the delay. Looks good to me.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-22 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 11:04 [patch] HID: picoLCD: off by one in dump_buff_as_hex() Dan Carpenter
2012-09-17 20:54 ` Bruno Prémont
2012-09-19 19:35 ` Bruno Prémont
2012-09-22 12:55 ` Dan Carpenter [this message]
2012-09-24 21:07 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922125512.GG4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bonbons@linux-vserver.org \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).