From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCHv3 2/4] Input: keypad: Add smsc ece1099 keypad driver Date: Thu, 4 Oct 2012 00:24:26 -0700 Message-ID: <20121004072426.GB14217@core.coreip.homeip.net> References: <1349089310-22134-1-git-send-email-sourav.poddar@ti.com> <20121002061829.GA3853@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Poddar, Sourav" Cc: devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, b-cousson@ti.com, balbi@ti.com, santosh.shilimkar@ti.com List-Id: linux-input@vger.kernel.org On Wed, Oct 03, 2012 at 11:26:46AM +0530, Poddar, Sourav wrote: > Hi Dmitry, > > On Tue, Oct 2, 2012 at 11:48 AM, Dmitry Torokhov > wrote: > > Hi Sourav, > > > > On Mon, Oct 01, 2012 at 04:31:50PM +0530, Sourav Poddar wrote: > >> From: G, Manjunath Kondaiah > >> > >> + > >> + /* Enable smsc keypad interrupts */ > >> + ret = smsc_write(dev, SMSC_KP_INT_MASK, 0xff); > >> + if (ret < 0) > >> + goto err2; > >> + > >> + return 0; > >> + > >> +err2: > >> + input_unregister_device(input); > >> +err1: > >> + input_free_device(input); > > > > Double free. > > > I believe what you are trying to say here is that we dont really > need a " input_unregister_device" (as also I checked in other keypad > implementations) and do a "unregister_device" in the remove api ?? What I was trying to say is that if input device has been registered then you need to call input_unregister_device() to unregister and free it, otherwise you need to call input_free_device(), but not both. Thanks. -- Dmitry