From: Thierry Reding <thierry.reding@avionic-design.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Shawn Guo <shawn.guo@linaro.org>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bryan Wu <bryan.wu@canonical.com>,
Richard Purdie <rpurdie@rpsys.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Ashish Jangam <ashish.jangam@kpitcummins.com>,
Andrew Jones <drjones@redhat.com>,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH] pwm: Get rid of HAVE_PWM
Date: Thu, 4 Oct 2012 20:29:31 +0200 [thread overview]
Message-ID: <20121004182931.GA7228@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <506DA487.9070400@metafoo.de>
[-- Attachment #1: Type: text/plain, Size: 942 bytes --]
On Thu, Oct 04, 2012 at 05:00:23PM +0200, Lars-Peter Clausen wrote:
> On 10/04/2012 08:06 AM, Thierry Reding wrote:
> > [...]
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 331d574..b38f23d 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -219,7 +219,8 @@ config MACH_JZ4740
> > select GENERIC_GPIO
> > select ARCH_REQUIRE_GPIOLIB
> > select SYS_HAS_EARLY_PRINTK
> > - select HAVE_PWM
> > + select PWM
> > + select PWM_JZ4740
> > select HAVE_CLK
> > select GENERIC_IRQ_CHIP
>
> I'm not sure if this is such a good idea, not all jz4740 based board
> necessarily require PWM.
This really only restores previous behaviour. But I agree that this is
potentially not what we want. Maybe we should just not select this for
any boards but rather leave it up to some default configuration. If so
the patch can be made simpler by just removing the HAVE_PWM entries.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-04 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 6:06 [PATCH] pwm: Get rid of HAVE_PWM Thierry Reding
2012-10-04 15:00 ` Lars-Peter Clausen
2012-10-04 18:29 ` Thierry Reding [this message]
2012-10-04 18:48 ` Lars-Peter Clausen
2012-10-04 19:13 ` Thierry Reding
2012-10-08 2:45 ` Eric Miao
2012-10-08 5:45 ` Thierry Reding
2012-10-07 4:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121004182931.GA7228@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=bryan.wu@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=drjones@redhat.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@arm.linux.org.uk \
--cc=ralf@linux-mips.org \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).