From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: keyboard: gpio-keys: Try to parse IRQ from device tree Date: Thu, 4 Oct 2012 23:23:15 -0700 Message-ID: <20121005062315.GB11112@core.coreip.homeip.net> References: <1349263201-422-1-git-send-email-t.figa@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1349263201-422-1-git-send-email-t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Tomasz Figa Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: linux-input@vger.kernel.org Hi Tomasz, On Wed, Oct 03, 2012 at 01:20:00PM +0200, Tomasz Figa wrote: > On modern platforms using device tree and non-legacy IRQ domains there > is usually no way to perform direct translation between GPIO and IRQ, > because the IRQ of interest is not mapped yet into sparse IRQ namespace. > > This patch modifies the gpio_keys driver to parse IRQ from device tree > and use gpio_to_irq only as a fallback. This means that this change would need to be applied to every driver that currently maps gpio to IRQ. Why can't gpio_to_irq() be fixed instead? Thanks. -- Dmitry