From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/2] input: gpio-keys: Add runtime support Date: Thu, 25 Oct 2012 08:57:09 +0100 Message-ID: <20121025075709.GE971@gmail.com> References: <1349964927-18619-1-git-send-email-lee.jones@linaro.org> <1349964927-18619-2-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: Shubhrajyoti Datta , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, Jonas Aaberg , Dmitry Torokhov , linux-input@vger.kernel.org, Philippe Langlais List-Id: linux-input@vger.kernel.org On Fri, 12 Oct 2012, Linus Walleij wrote: > On Thu, Oct 11, 2012 at 4:22 PM, Shubhrajyoti Datta > wrote: >=20 > >> @@ -526,6 +527,7 @@ static int gpio_keys_open(struct input_dev *in= put) > >> { > >> struct gpio_keys_drvdata *ddata =3D input_get_drvdata(inpu= t); > >> > >> + pm_runtime_get_sync(input->dev.parent); > > > > I am not an expert of the runtime. > > > > However would be grateful if you explain me what it actually do. >=20 > This increase the reference count of the runtime status container > for the device. _sync makes sure it happens now. >=20 > Consult: > Documentation/power/runtime_pm.txt >=20 > > Also I did not see any runtime suspend/ resume handlers populated. >=20 > It is not necessary to handle the power state at the driver level, > it can just as well be handled by the voltage/power domain, > or at the class, type or bus level. >=20 > But the individual driver has to notify the system upward if it > needs to be powered on or when it may or must be relaxed. > > Yours, > Linus Walleij =46riendly poke. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog