From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Daniel Mack <zonque@gmail.com>,
linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonas ABERG <jonas.aberg@stericsson.com>
Subject: Re: [PATCH] Input: gpio_keys: allocate pins
Date: Thu, 25 Oct 2012 09:20:10 +0100 [thread overview]
Message-ID: <20121025082010.GA3348@gmail.com> (raw)
In-Reply-To: <CACRpkdbr4VHJ+gNZjK43FmSU=p5FGdxqmOkkAz-VWqUCQ=R=5A@mail.gmail.com>
On Thu, 25 Oct 2012, Linus Walleij wrote:
> On Thu, Oct 25, 2012 at 9:58 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Fri, 12 Oct 2012, Linus Walleij wrote:
> (...)
> >> Is biasing what you need to do?
> (...)
> >> All I really want is that platforms have a clear idea about
> >> how and where the pins will be handled, and that if GPIO
> >> and pinctrl handle the same lines, they need to interact.
> >>
> >> Yours,
> >> Linus Walleij
> >
> > Friendly poke.
>
> I don't know how to respond to that? I asked a question about
> what the intent of the patch was and the generic thinking
> behind this approach and it remains unanswered.
>
> I think I have seen other patches doing the proper thing
> for pinctrl-single by implementing the proper
> pinctrl_request_gpio()
> pinctrl_free_gpio()
> pinctrl_gpio_direction_input()
> pinctrl_gpio_direction_output()
> in that very GPIO driver.
>
> So I suspect that this patch should be dropped, unless you
> have some other compelling usecase to bring to the show?
Actually it is I who is confused. I thought you answered some of
the questions which was posed to me. The poke was a kind of does
anyone else have any comments.
I'm happy for the patch to be dropped. Does that mean it can
be eradicated from the internal tree too then, because that is
actually a suitable end result.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-25 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 15:55 [PATCH] Input: gpio_keys: allocate pins Daniel Mack
2012-10-12 21:26 ` Linus Walleij
2012-10-12 21:27 ` Daniel Mack
2012-10-12 21:37 ` Linus Walleij
2012-10-12 21:40 ` Daniel Mack
2012-10-12 21:44 ` Linus Walleij
2012-10-25 7:58 ` Lee Jones
2012-10-25 8:08 ` Linus Walleij
2012-10-25 8:20 ` Lee Jones [this message]
2012-10-25 8:20 ` Daniel Mack
2012-10-12 21:35 ` Dmitry Torokhov
2012-10-12 21:40 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025082010.GA3348@gmail.com \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jonas.aberg@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).