* [PATCH RESEND] sensor-hub: Remove pointless NULL check
@ 2012-10-25 14:13 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2012-10-25 14:13 UTC (permalink / raw)
To: linux-input, srinivas.pandruvada
From: Alan Cox <alan@linux.intel.com>
report cannot be NULL, fortunately as we use it before we check !
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/hid/hid-sensor-hub.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index d9d73e9..4ff2497 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -437,9 +437,6 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
ptr = raw_data;
ptr++; /*Skip report id*/
- if (!report)
- goto err_report;
-
spin_lock_irqsave(&pdata->lock, flags);
for (i = 0; i < report->maxfield; ++i) {
@@ -485,7 +482,6 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
callback->pdev);
spin_unlock_irqrestore(&pdata->lock, flags);
-err_report:
return 1;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-10-25 14:11 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-25 14:13 [PATCH RESEND] sensor-hub: Remove pointless NULL check Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).