* [PATCH] Input: mouse: alps: print small buffers via %*ph
@ 2012-10-26 13:42 Andy Shevchenko
2012-10-31 5:55 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2012-10-26 13:42 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Andy Shevchenko
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/input/mouse/alps.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index cf5af1f..b4a3faf 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -766,10 +766,9 @@ static psmouse_ret_t alps_handle_interleaved_ps2(struct psmouse *psmouse)
psmouse->packet[4] |
psmouse->packet[5]) & 0x80) ||
(!alps_is_valid_first_byte(priv->i, psmouse->packet[6]))) {
- psmouse_dbg(psmouse,
- "refusing packet %x %x %x %x (suspected interleaved ps/2)\n",
- psmouse->packet[3], psmouse->packet[4],
- psmouse->packet[5], psmouse->packet[6]);
+ psmouse_dbg(psmouse, "refusing packet %4ph "
+ "(suspected interleaved ps/2)\n",
+ psmouse->packet + 3);
return PSMOUSE_BAD_DATA;
}
@@ -830,10 +829,9 @@ static void alps_flush_packet(unsigned long data)
if ((psmouse->packet[3] |
psmouse->packet[4] |
psmouse->packet[5]) & 0x80) {
- psmouse_dbg(psmouse,
- "refusing packet %x %x %x (suspected interleaved ps/2)\n",
- psmouse->packet[3], psmouse->packet[4],
- psmouse->packet[5]);
+ psmouse_dbg(psmouse, "refusing packet %3ph "
+ "(suspected interleaved ps/2)\n",
+ psmouse->packet + 3);
} else {
alps_process_packet(psmouse);
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: mouse: alps: print small buffers via %*ph
2012-10-26 13:42 [PATCH] Input: mouse: alps: print small buffers via %*ph Andy Shevchenko
@ 2012-10-31 5:55 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2012-10-31 5:55 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-input
On Fri, Oct 26, 2012 at 04:42:58PM +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied, thank you Andy.
> ---
> drivers/input/mouse/alps.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index cf5af1f..b4a3faf 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -766,10 +766,9 @@ static psmouse_ret_t alps_handle_interleaved_ps2(struct psmouse *psmouse)
> psmouse->packet[4] |
> psmouse->packet[5]) & 0x80) ||
> (!alps_is_valid_first_byte(priv->i, psmouse->packet[6]))) {
> - psmouse_dbg(psmouse,
> - "refusing packet %x %x %x %x (suspected interleaved ps/2)\n",
> - psmouse->packet[3], psmouse->packet[4],
> - psmouse->packet[5], psmouse->packet[6]);
> + psmouse_dbg(psmouse, "refusing packet %4ph "
> + "(suspected interleaved ps/2)\n",
> + psmouse->packet + 3);
> return PSMOUSE_BAD_DATA;
> }
>
> @@ -830,10 +829,9 @@ static void alps_flush_packet(unsigned long data)
> if ((psmouse->packet[3] |
> psmouse->packet[4] |
> psmouse->packet[5]) & 0x80) {
> - psmouse_dbg(psmouse,
> - "refusing packet %x %x %x (suspected interleaved ps/2)\n",
> - psmouse->packet[3], psmouse->packet[4],
> - psmouse->packet[5]);
> + psmouse_dbg(psmouse, "refusing packet %3ph "
> + "(suspected interleaved ps/2)\n",
> + psmouse->packet + 3);
> } else {
> alps_process_packet(psmouse);
> }
> --
> 1.7.10.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-31 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 13:42 [PATCH] Input: mouse: alps: print small buffers via %*ph Andy Shevchenko
2012-10-31 5:55 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).