From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Roland Stigge <stigge@antcom.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
grant.likely@secretlab.ca
Subject: Re: [PATCH] Input: select INPUT_MATRIXKMAP for lpc32xx-keys
Date: Tue, 30 Oct 2012 22:55:49 -0700 [thread overview]
Message-ID: <20121031055549.GE31983@core.coreip.homeip.net> (raw)
In-Reply-To: <1351323648-18645-1-git-send-email-stigge@antcom.de>
On Sat, Oct 27, 2012 at 09:40:48AM +0200, Roland Stigge wrote:
> This patch adds a "select" dependency of KEYBOARD_LPC32XX on INPUT_MATRIXKMAP,
> as the other drivers are doing in this regard. This fixes the following compile
> error if KEYBOARD_LPC32XX is enabled but INPUT_MATRIXKMAP is not:
>
> drivers/input/keyboard/lpc32xx-keys.c:230: undefined reference to
> `matrix_keypad_build_keymap'
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Applied, thank you Roland.
>
> ---
> drivers/input/keyboard/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.orig/drivers/input/keyboard/Kconfig
> +++ linux-2.6/drivers/input/keyboard/Kconfig
> @@ -335,6 +335,7 @@ config KEYBOARD_LOCOMO
> config KEYBOARD_LPC32XX
> tristate "LPC32XX matrix key scanner support"
> depends on ARCH_LPC32XX && OF
> + select INPUT_MATRIXKMAP
> help
> Say Y here if you want to use NXP LPC32XX SoC key scanner interface,
> connected to a key matrix.
--
Dmitry
prev parent reply other threads:[~2012-10-31 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 7:40 [PATCH] Input: select INPUT_MATRIXKMAP for lpc32xx-keys Roland Stigge
2012-10-31 5:55 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031055549.GE31983@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).