* [patch] Input: wacom - fix a check for WACOM_24HDT
@ 2012-10-29 8:49 Dan Carpenter
2012-10-31 5:57 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-10-29 8:49 UTC (permalink / raw)
To: Dmitry Torokhov, Jason Gerecke
Cc: Chris Bagwell, Ping Cheng, Greg Kroah-Hartman, linux-input,
kernel-janitors
The current condition is always true. From the context, it looks like
we should be checking if ->type == WACOM_24HDT.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
index 2c1e12b..858ad44 100644
--- a/drivers/input/tablet/wacom_sys.c
+++ b/drivers/input/tablet/wacom_sys.c
@@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
features->pktlen = WACOM_PKGLEN_TPC2FG;
}
- if (features->type == MTSCREEN || WACOM_24HDT)
+ if (features->type == MTSCREEN || features->type == WACOM_24HDT)
features->pktlen = WACOM_PKGLEN_MTOUCH;
if (features->type == BAMBOO_PT) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] Input: wacom - fix a check for WACOM_24HDT
2012-10-29 8:49 [patch] Input: wacom - fix a check for WACOM_24HDT Dan Carpenter
@ 2012-10-31 5:57 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2012-10-31 5:57 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jason Gerecke, Chris Bagwell, Ping Cheng, Greg Kroah-Hartman,
linux-input, kernel-janitors
On Mon, Oct 29, 2012 at 11:49:56AM +0300, Dan Carpenter wrote:
> The current condition is always true. From the context, it looks like
> we should be checking if ->type == WACOM_24HDT.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you Dan, however I already have a patch from Jason Gerecke
addressing this issue.
>
> diff --git a/drivers/input/tablet/wacom_sys.c b/drivers/input/tablet/wacom_sys.c
> index 2c1e12b..858ad44 100644
> --- a/drivers/input/tablet/wacom_sys.c
> +++ b/drivers/input/tablet/wacom_sys.c
> @@ -391,7 +391,7 @@ static int wacom_parse_hid(struct usb_interface *intf,
> features->pktlen = WACOM_PKGLEN_TPC2FG;
> }
>
> - if (features->type == MTSCREEN || WACOM_24HDT)
> + if (features->type == MTSCREEN || features->type == WACOM_24HDT)
> features->pktlen = WACOM_PKGLEN_MTOUCH;
>
> if (features->type == BAMBOO_PT) {
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-31 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-29 8:49 [patch] Input: wacom - fix a check for WACOM_24HDT Dan Carpenter
2012-10-31 5:57 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).