Re: [PATCH v3] input: pwm-beeper: Add devicetree probing support

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Dmitry,

On Sat, Nov 03, 2012 at 12:03:01PM -0700, Dmitry Torokhov wrote:
> Hi Sascha.
> 
> On Fri, Nov 02, 2012 at 09:44:02AM +0100, Sascha Hauer wrote:
> >  
> > -	beeper->pwm = pwm_request(pwm_id, "pwm beeper");
> > +	beeper->pwm = pwm_get(&pdev->dev, NULL);
> > +	if (IS_ERR(beeper->pwm)) {
> > +		dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
> 
> This is not an error, I'll switch it over to dev_dbg().

This is cut and paste from some other driver. I suppose it's dev_err to
motivate people to update their boards. Anyway, dev_dbg is fine with me.

Thanks,
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |