From: Alban Bedel <alban.bedel@avionic-design.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: tca8418 - Add support for shared interrupt
Date: Tue, 6 Nov 2012 17:34:30 +0100 [thread overview]
Message-ID: <20121106173430.2d959c10@avionic-0020.adnet.avionic-design.de> (raw)
In-Reply-To: <20121105185806.GA18149@core.coreip.homeip.net>
On Mon, 5 Nov 2012 10:58:06 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> I do not think that using ONESHOT IRQ handlers in shared interrupt
> configuration is a good idea as that interrupt will stay masked until
> the keypad is done processing it, which may take some time.
I don't really see what the problem is, shared ONESHOT handlers are
supported by the IRQ framework. The IRQ line of this device is an open
drain and so can be shared, and is shared on the hardware I'm using!
I agree that the interrupt masking time might rise a little if many
devices share the same line, but that's the normal drawback of shared
interrupts.
Alban
next prev parent reply other threads:[~2012-11-06 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 16:14 [PATCH] Input: tca8418 - Add support for shared interrupt Alban Bedel
2012-11-05 18:58 ` Dmitry Torokhov
2012-11-06 16:34 ` Alban Bedel [this message]
2012-11-08 16:45 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106173430.2d959c10@avionic-0020.adnet.avionic-design.de \
--to=alban.bedel@avionic-design.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).