From: "Henrik Rydberg" <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] input: fix input-mt kernel-doc warning
Date: Thu, 8 Nov 2012 18:56:09 +0100 [thread overview]
Message-ID: <20121108175609.GA11114@polaris.bitmath.org> (raw)
In-Reply-To: <20121108170431.GD8877@core.coreip.homeip.net>
Hi Dmitry,
> > > From: Randy Dunlap <rdunlap@infradead.org>
> > >
> > > Fix new kernel-doc warning in input-mt.c:
> > >
> > > Warning(drivers/input/input-mt.c:38): No description found for parameter 'flags'
> >
> > Thanks for the patch. It seemed reasonable to expand the function
> > documentation a bit as well, hope you are alright with the patch
> > below, Dmitry, care to pick this up for 3.7? Otherwise I can carry it
> > for 3.8.
>
> Randy, Henrik,
>
> I'll try getting it in 3.7.
Seems there were more warnings introduced in 3.7-rc1... adding the
patch below seems to fix all of them. I guess you want to merge the
former patch into this one.
Thanks,
Henrik
>From 1ba1d5e18057260a3203625eaee22cc94393fda3 Mon Sep 17 00:00:00 2001
From: Henrik Rydberg <rydberg@euromail.se>
Date: Thu, 8 Nov 2012 18:48:22 +0100
Subject: [PATCH] Input: Document new struct members
Fixes kernel-doc warnings for the members added in 3.7-rc1.
Signed-off-by: Henrik Rydberg <rydberg@euromail.se>
---
include/linux/input.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/input.h b/include/linux/input.h
index cab994b..2d55e55 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -112,6 +112,9 @@ struct input_value {
* @h_list: list of input handles associated with the device. When
* accessing the list dev->mutex must be held
* @node: used to place the device onto input_dev_list
+ * @num_vals: number of values queued in the current frame
+ * @max_vals: maximum number of values queued in a frame
+ * @vals: array of values queued in the current frame
*/
struct input_dev {
const char *name;
--
1.8.0
next prev parent reply other threads:[~2012-11-08 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 1:07 [PATCH] input: fix input-mt kernel-doc warning Randy Dunlap
2012-11-07 19:46 ` Henrik Rydberg
2012-11-08 17:04 ` Dmitry Torokhov
2012-11-08 17:56 ` Henrik Rydberg [this message]
2012-11-14 18:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121108175609.GA11114@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).