From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [RFC] staging: ste_rmi4: merge into the main kernel tree Date: Thu, 15 Nov 2012 10:55:23 -0800 Message-ID: <20121115185522.GA4077@core.coreip.homeip.net> References: <20121103013623.0f3a1b28168a9a42881b0b00@tw.synaptics.com> <20121113201212.8550fb074e1f7cce78f29d97@tw.synaptics.com> <20121113175309.GA3601@polaris.bitmath.org> <20121114180401.GC29131@core.coreip.homeip.net> <20121115064359.GA17551@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:63432 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1768711Ab2KOSz2 (ORCPT ); Thu, 15 Nov 2012 13:55:28 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Linus Walleij Cc: Alexandra Chin , Henrik Rydberg , Linux Kernel , Linux Input , Linus Walleij , Naveen Kumar Gaddipati , Mahesh Srinivasan , Alex Chang , Scott Lin , Christopher Heiny Hi Linus, On Thu, Nov 15, 2012 at 06:41:26PM +0100, Linus Walleij wrote: > On Thu, Nov 15, 2012 at 7:43 AM, Dmitry Torokhov > wrote: > > > In this case you need to enumerate the benefits of this driver over > > unified driver and show why the unified driver can't be fixed. > > The benefit is that the ugliness in > drivers/staging/ste_rmi4/board-mop500-u8500uib-rmi4.c > can be avoided, as today we're unable to pass the compulsory > platform data in any sane way. I'm being told that this weak symbol > override actually does not really work... especially if there are more > than 1 I2C device on the bus :-P I am confused as to why this would be a benefit of ste_rmi4 over full RMI4 implementation from Christopher's group? I think what we really need is to accelerate work on the full driver so it is in mainline in 3.9ish. Thanks. -- Dmitry