linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Igor Grinberg <grinberg@compulab.co.il>
Cc: Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@ti.com>,
	linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting
Date: Tue, 20 Nov 2012 00:21:36 -0800	[thread overview]
Message-ID: <20121120082136.GB28115@core.coreip.homeip.net> (raw)
In-Reply-To: <1353341038-14381-1-git-send-email-grinberg@compulab.co.il>

On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote:
> Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the
> pendown GPIO debounce time setting by the below sequence:
> 
>   gpio_request_one()
>   gpio_set_debounce()
>   gpio_free()
> 
> It also revealed a bug in the OMAP GPIO handling code which prevented
> the GPIO debounce clock to be disabled and CORE transition to low power
> states.
> 
> Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on
> free/reset) fixes the OMAP GPIO handling code by making sure that the
> GPIO debounce clock gets disabled if no GPIO is requested from current
> bank.
> 
> While fixing the OMAP GPIO handling code (in the right way), the above
> commit makes the gpio_request->set_debounce->free sequence invalid as
> after freeing the GPIO, the debounce settings are lost.
> 
> This patch set:
> 1) Adds the pendown GPIO debounce time setting to the platform data
>    structure of the ads7846 driver.
> 2) Fixes the OMAP platform code to pass the debounce time value
>    to the driver instead of handling it by itself.
> 
> Igor Grinberg (2):
>   ads7846: enable pendown GPIO debounce time setting
>   ARM: OMAP: ads7846: fix pendown debounce setting
> 

Makes sense to me. Tony, I have some stuff to push for 3.7 final, mind
if I pick OMAP change as well?

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2012-11-20  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 16:03 [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting Igor Grinberg
2012-11-19 16:03 ` [PATCH 1/2] ads7846: enable pendown GPIO debounce time setting Igor Grinberg
2012-11-19 17:01   ` [PATCH v2 " Igor Grinberg
2012-11-19 16:03 ` [PATCH 2/2] ARM: OMAP: ads7846: fix pendown debounce setting Igor Grinberg
2012-11-21 19:08   ` Tony Lindgren
2012-11-20  8:21 ` Dmitry Torokhov [this message]
2012-11-21 19:09   ` [PATCH 0/2] " Tony Lindgren
2012-11-21 20:55     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121120082136.GB28115@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=grinberg@compulab.co.il \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).