From: Arnd Bergmann <arnd@arndb.de>
To: Stefan Nilsson <stefan.nilsson@unixphere.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
rob.herring@calxeda.com, matthias.schmidt@epcos.com,
armin.schober@epcos.com, eric.andersson@unixphere.com
Subject: Re: [PATCH 1/1] input: added driver support for the t5400 pressure sensor.
Date: Tue, 20 Nov 2012 21:21:42 +0000 [thread overview]
Message-ID: <201211202121.42414.arnd@arndb.de> (raw)
In-Reply-To: <1353445355-2517-2-git-send-email-stefan.nilsson@unixphere.com>
On Tuesday 20 November 2012, Stefan Nilsson wrote:
> +Optional properties:
> +- gpio-irq: platform gpio pin connected to the t5400 irq pin
> +- op-mode: operation modes to be set according to enum t5400_op_mode in t5400.h
> +
> +Example of having the t5400 on an i2c bus:
> +
> +pressure@77 {
> + compatible = "tdk-epcos,t5400";
> + reg = <0x77>;
> + gpio-irq = <18>;
> + op-mode = <1>;
The way that the "gpio-irq" is specified doesn't look right. If you want to specify
a gpio line, use the gpio binding. If you just want to specify an interrupt, use the
"interrupts" property with a proper interrupt-parent.
> + int gpio-irq;
> ...
> + if (t5400->gpio-irq > 0) {
> + error = request_threaded_irq(t5400->gpio-irq, NULL,
I'm pretty sure this doesn't even compile. '-' is not part of an identifier in C.
Arnd
next prev parent reply other threads:[~2012-11-20 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 21:02 [PATCH 0/1] input: added driver support for the t5400 pressure sensor Stefan Nilsson
2012-11-20 21:02 ` [PATCH 1/1] " Stefan Nilsson
2012-11-20 21:21 ` Arnd Bergmann [this message]
2012-11-21 7:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211202121.42414.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=armin.schober@epcos.com \
--cc=dmitry.torokhov@gmail.com \
--cc=eric.andersson@unixphere.com \
--cc=linux-input@vger.kernel.org \
--cc=matthias.schmidt@epcos.com \
--cc=rob.herring@calxeda.com \
--cc=stefan.nilsson@unixphere.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).