From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-input@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH RFC] input: Add new driver for GPIO beeper
Date: Wed, 21 Nov 2012 10:40:33 -0800 [thread overview]
Message-ID: <20121121184033.GC18950@core.coreip.homeip.net> (raw)
In-Reply-To: <1353511962-21883-1-git-send-email-shc_work@mail.ru>
Hi Alexander,
On Wed, Nov 21, 2012 at 07:32:42PM +0400, Alexander Shiyan wrote:
> This patch adds a new driver for the beeper controlled via GPIO pin.
> The driver does not depend on the architecture and is positioned as
> a replacement for the specific drivers that are used for this function,
> for example drivers/input/misc/ixp4xx-beeper.
> Since this patch is only RFC, comments are welcome.
This looks reasonable, but if it is to be a generic solution it should
handle GPIOs that need sleep so you need to schedule a work item from
event() and toggle gpio from there.
Thanks.
--
Dmitry
prev parent reply other threads:[~2012-11-21 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 15:32 [PATCH RFC] input: Add new driver for GPIO beeper Alexander Shiyan
2012-11-21 18:40 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121184033.GC18950@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-input@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).