From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/2] ARM: OMAP: ads7846: fix pendown debounce setting Date: Wed, 21 Nov 2012 12:55:24 -0800 Message-ID: <20121121205524.GB25470@core.coreip.homeip.net> References: <1353341038-14381-1-git-send-email-grinberg@compulab.co.il> <20121120082136.GB28115@core.coreip.homeip.net> <20121121190929.GF18567@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-da0-f46.google.com ([209.85.210.46]:64524 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964798Ab2KUUz2 (ORCPT ); Wed, 21 Nov 2012 15:55:28 -0500 Content-Disposition: inline In-Reply-To: <20121121190929.GF18567@atomide.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Tony Lindgren Cc: Igor Grinberg , Kevin Hilman , linux-input@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wed, Nov 21, 2012 at 11:09:30AM -0800, Tony Lindgren wrote: > * Dmitry Torokhov [121120 00:23]: > > On Mon, Nov 19, 2012 at 06:03:56PM +0200, Igor Grinberg wrote: > > > Commit 97ee9f01 (ARM: OMAP: fix the ads7846 init code) have enabled the > > > pendown GPIO debounce time setting by the below sequence: > > > > > > gpio_request_one() > > > gpio_set_debounce() > > > gpio_free() > > > > > > It also revealed a bug in the OMAP GPIO handling code which prevented > > > the GPIO debounce clock to be disabled and CORE transition to low power > > > states. > > > > > > Commit c9c55d9 (gpio/omap: fix off-mode bug: clear debounce settings on > > > free/reset) fixes the OMAP GPIO handling code by making sure that the > > > GPIO debounce clock gets disabled if no GPIO is requested from current > > > bank. > > > > > > While fixing the OMAP GPIO handling code (in the right way), the above > > > commit makes the gpio_request->set_debounce->free sequence invalid as > > > after freeing the GPIO, the debounce settings are lost. > > > > > > This patch set: > > > 1) Adds the pendown GPIO debounce time setting to the platform data > > > structure of the ads7846 driver. > > > 2) Fixes the OMAP platform code to pass the debounce time value > > > to the driver instead of handling it by itself. > > > > > > Igor Grinberg (2): > > > ads7846: enable pendown GPIO debounce time setting > > > ARM: OMAP: ads7846: fix pendown debounce setting > > > > > > > Makes sense to me. Tony, I have some stuff to push for 3.7 final, mind > > if I pick OMAP change as well? > > No please go ahead, I just acked the related patch. Thanks Tony. -- Dmitry