[PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

[PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

[Shubhrajyoti D]

The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used
so remove them.

Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
 drivers/input/keyboard/omap4-keypad.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index c05f98c..d2b72b7 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -36,8 +36,6 @@
 
 /* OMAP4 registers */
 #define OMAP4_KBD_REVISION		0x00
-#define OMAP4_KBD_SYSCONFIG		0x10
-#define OMAP4_KBD_SYSSTATUS		0x14
 #define OMAP4_KBD_IRQSTATUS		0x18
 #define OMAP4_KBD_IRQENABLE		0x1C
 #define OMAP4_KBD_WAKEUPENABLE		0x20
-- 
1.7.5.4

Re: [PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

[Dmitry Torokhov]

On Mon, Nov 26, 2012 at 04:21:19PM +0530, Shubhrajyoti D wrote:
> The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used
> so remove them.

They document the existing registers and do not add bloat to the
generated objects so let's leave them be.

Thanks.

-- 
Dmitry

Re: [PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

[Shubhrajyoti Datta]

[-- Attachment #1.1: Type: text/plain, Size: 652 bytes --]

On Mon, Nov 26, 2012 at 11:31 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com
> wrote:

> On Mon, Nov 26, 2012 at 04:21:19PM +0530, Shubhrajyoti D wrote:
> > The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used
> > so remove them.
>
> They document the existing registers and do not add bloat to the
> generated objects so let's leave them be.
>

The objective of the patch is not to prevent bloat.

Actually these registers have power/system impact so it was decided that
the drivers will not
configure the sysc registers (infact not define). Currently hwmod
configures the registers.

To be safe I thought of deleting it.


> Thanks.
>

[-- Attachment #1.2: Type: text/html, Size: 1272 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] Input: omap4-keypad: Remove the OMAP4_KBD_SYSCONFIG and OMAP4_KBD_SYSSTATUS

[Shubhrajyoti Datta]

On Mon, Nov 26, 2012 at 11:31 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Mon, Nov 26, 2012 at 04:21:19PM +0530, Shubhrajyoti D wrote:
>> The macros OMAP4_KBD_SYSSTATUS and OMAP4_KBD_SYSSTATUS are not used
>> so remove them.
>
> They document the existing registers and do not add bloat to the
> generated objects so let's leave them be.

The objective of the patch is not to prevent bloat.

Actually these registers have power/system impact so it was decided
that the drivers will not
configure the sysc registers (infact not define). Currently hwmod
configures the registers.

To be safe I thought of deleting it.


>
> Thanks.
>
> --
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html