From: Chris Moeller <kode54@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Chris Moeller <kode54@gmail.com>
Subject: [PATCH v2 0/1] Input: xpad - Implement wireless controller LED setting and fix connect time LED setting
Date: Fri, 30 Nov 2012 13:54:06 -0800 [thread overview]
Message-ID: <20121130135406.38c9bdc9@umaro.lan> (raw)
I've submitted versions of this with prior patch sets, and this part
was never accepted, possibly because it depended on other patches to
work, or possibly because it wasn't so cleanly organized. This time,
I've split the LED setting command off into its own static function,
then call that on controller connect and optionally on LED setting
commands. The static function does not include any locking, because
locking inside the function which receives the incoming packets
deadlocks the driver, and does not appear to be necessary anyway.
It also removes all traces of the original bulk out function which was
designed for the purpose of setting the LED status on connect, as I
found that it actually does not work at all. It appears to try to send
the data, but nothing actually happens to the controller LEDs.
next reply other threads:[~2012-11-30 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 21:54 Chris Moeller [this message]
2012-11-30 22:30 ` [PATCH v2 0/1] Input: xpad - Implement wireless controller LED setting and fix connect time LED setting Dmitry Torokhov
2012-12-01 4:13 ` Chris Moeller
2012-12-03 7:43 ` Dmitry Torokhov
2012-12-10 10:58 ` Chris Moeller
2012-12-10 12:43 ` Chris Moeller
[not found] ` <20121210044354.5d562079-mv0dIculHdT/PtFMR13I2A@public.gmane.org>
2012-12-10 13:24 ` Chris Moeller
2013-01-07 1:37 ` Chris Moeller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130135406.38c9bdc9@umaro.lan \
--to=kode54@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).